Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Quarkus Test Framework to 1.3.0.Beta6 and disable OpenShift tests and Hibernate Reactive #1068

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Feb 17, 2023

Summary

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-openshift-runs branch from 8a0c047 to c693ee6 Compare February 17, 2023 13:43
@michalvavrik michalvavrik changed the title Bump Quarkus Test Framework to 1.3.0.Beta6 and disable OpenShift tests Bump Quarkus Test Framework to 1.3.0.Beta6 and disable OpenShift tests and Hibernate Reactive Feb 17, 2023
@michalvavrik michalvavrik requested a review from mjurc February 17, 2023 13:45
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-openshift-runs branch from c693ee6 to 2864135 Compare February 17, 2023 14:26
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

michalvavrik commented Feb 17, 2023

OC failures:

  • OpenShiftApiServerConfigMapConfigIT, OpenShiftApiServerConfigSecretConfigIT, OpenShiftFileSystemConfigSecretConfigIT, need to be disabled, are failing due to OpenShift deployment fails while instantiating the build quarkusio/quarkus#31228
  • then there is couple of failures java.lang.NoClassDefFoundError: io/fabric8/kubernetes/client/vertx/VertxHttpClientBuilder. I remember I already saw it when I experimented with adding io.fabric8:openshift-client where it shouldn't be, but here it looks like a Quarkus bug; I can't see anything wrong we are doing. Not related to changes in FW or in this PR, but I need to investigate to be 100 % sure it's not on our side (create standalone reproducer).

I'll disable config tests and address other failures (probably open issue and disable tests) in a separate PR as:

  • this PR fixes TS compilation
  • with this PR, there are way less OC failures

@michalvavrik michalvavrik merged commit bb74e86 into quarkus-qe:main Feb 17, 2023
@michalvavrik michalvavrik deleted the feature/fix-openshift-runs branch February 17, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants