-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the Hibernate Reactive modules #31217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll test it locally too, so to get a preview of next issue to look into
This comment has been minimized.
This comment has been minimized.
80610ba
to
1ea096b
Compare
The first commit will have to be reverted exactly as it also removes some code in the SmallRye Reactive Messaging Kafka extension: The second commit should stay. |
This comment has been minimized.
This comment has been minimized.
We want to make progress on the Hibernate ORM integration and we will disable the Hibernate Reactive modules as they are not working yet. We will enable them again once we have a Hibernate Reactive version working with Hibernate ORM 6.2.
No need for that so let's rely on dependencies that are less sensitive.
1ea096b
to
e8113db
Compare
Failing Jobs - Building e8113db
Full information is available in the Build summary check run. Failures⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
⚙️ Quickstarts Compilation - JDK 17 #- Failing: hibernate-reactive-panache-quickstart hibernate-reactive-quickstart hibernate-reactive-routes-quickstart and 3 more
📦 hibernate-reactive-panache-quickstart✖ 📦 hibernate-reactive-quickstart✖ 📦 hibernate-reactive-routes-quickstart✖ 📦 hibernate-reactive-stateless-quickstart✖ 📦 kafka-panache-reactive-quickstart✖ 📦 security-webauthn-quickstart✖ |
Quickstarts will be dealt with in quarkusio/quarkus-quickstarts#1240 . |
We want to make progress on the Hibernate ORM integration and we will disable the Hibernate Reactive modules as they are not working yet.
We will enable them again once we have a Hibernate Reactive version working with Hibernate ORM 6.2.
/cc @Sanne @maxandersen