Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Hibernate Reactive modules #31217

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 16, 2023

We want to make progress on the Hibernate ORM integration and we will disable the Hibernate Reactive modules as they are not working yet.

We will enable them again once we have a Hibernate Reactive version working with Hibernate ORM 6.2.

/cc @Sanne @maxandersen

Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll test it locally too, so to get a preview of next issue to look into

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member Author

gsmet commented Feb 16, 2023

The first commit will have to be reverted exactly as it also removes some code in the SmallRye Reactive Messaging Kafka extension: Disable the Hibernate Reactive modules.

The second commit should stay.

@quarkus-bot

This comment has been minimized.

We want to make progress on the Hibernate ORM integration and we will
disable the Hibernate Reactive modules as they are not working yet.

We will enable them again once we have a Hibernate Reactive version
working with Hibernate ORM 6.2.
No need for that so let's rely on dependencies that are less sensitive.
@gsmet gsmet force-pushed the disable-hr-for-now branch from 1ea096b to e8113db Compare February 16, 2023 17:03
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Feb 16, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 16, 2023

Failing Jobs - Building e8113db

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <2> but was: <1>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: hibernate-reactive-panache-quickstart hibernate-reactive-quickstart hibernate-reactive-routes-quickstart and 3 more

📦 hibernate-reactive-panache-quickstart

Failed to execute goal on project hibernate-reactive-panache-quickstart: Could not resolve dependencies for project org.acme:hibernate-reactive-panache-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive-panache:jar:999-SNAPSHOT

📦 hibernate-reactive-quickstart

Failed to execute goal on project hibernate-reactive-quickstart: Could not resolve dependencies for project org.acme:hibernate-reactive-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive:jar:999-SNAPSHOT

📦 hibernate-reactive-routes-quickstart

Failed to execute goal on project hibernate-reactive-routes-quickstart: Could not resolve dependencies for project org.acme:hibernate-reactive-routes-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive:jar:999-SNAPSHOT

📦 hibernate-reactive-stateless-quickstart

Failed to execute goal on project hibernate-reactive-stateless-quickstart: Could not resolve dependencies for project org.acme:hibernate-reactive-stateless-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive:jar:999-SNAPSHOT

📦 kafka-panache-reactive-quickstart

Failed to execute goal on project kafka-panache-reactive-quickstart: Could not resolve dependencies for project org.acme:kafka-panache-reactive-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive-panache:jar:999-SNAPSHOT

📦 security-webauthn-quickstart

Failed to execute goal on project security-webauthn-quickstart: Could not resolve dependencies for project org.acme:security-webauthn-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-hibernate-reactive-panache:jar:999-SNAPSHOT

@gsmet
Copy link
Member Author

gsmet commented Feb 17, 2023

Quickstarts will be dealt with in quarkusio/quarkus-quickstarts#1240 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/panache area/reactive-messaging area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants