Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expected CLI help for command 'version' #1072

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Update expected CLI help for command 'version' #1072

merged 1 commit into from
Feb 23, 2023

Conversation

michalvavrik
Copy link
Member

Summary

Fixes Quarkus CLI failing test. quarkusio/quarkus#29558 updated help for 'version' command.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from pjgg February 22, 2023 18:49
pjgg
pjgg approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit a8f9f44 into quarkus-qe:main Feb 23, 2023
@michalvavrik michalvavrik deleted the feature/correct-expected-cli-helpl-for-version branch February 23, 2023 11:37
@michalvavrik michalvavrik mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @pjgg