-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better tooling experience for Quarkus project info and update #29558
Conversation
...ojects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/update/Operation.java
Outdated
Show resolved
Hide resolved
...ls/devtools-common/src/main/java/io/quarkus/devtools/project/update/QuarkusUpdateRecipe.java
Show resolved
Hide resolved
...ls/devtools-common/src/main/java/io/quarkus/devtools/project/update/QuarkusUpdateRecipe.java
Outdated
Show resolved
Hide resolved
independent-projects/tools/devtools-common/src/test/resources/other-recipes.yaml
Show resolved
Hide resolved
fac1c9b
to
34c52d1
Compare
34c52d1
to
dc70918
Compare
devtools/cli/src/main/java/io/quarkus/cli/build/MavenRunner.java
Outdated
Show resolved
Hide resolved
dc70918
to
a6dc474
Compare
FYI @ebullient |
@aloubyansky @maxandersen I need to print the open-rewrite command, but I am not sure what version to put? Maybe the version should be provided by the quarkus-update-recipe jar as metadata? |
Version of what ? Openrewrite? Put a hardcoded version that cli knows about. The platform won't know which is better. Users can change it when running the actual command if need be. Ps. Would be great with just a little bit of context in the pr especially with this many changes what this pr is trying to do (and possibly what it doesn't cover yet if the #29000) |
Ok 👍
@maxandersen this was still a draft, I pushed ASAP to allow Alexey to do his part. I've updated the description with everything. |
Just a small thing we could change the
qss update --help
Suggest recommended project updates with the possibility to apply them.
Usage: quarkus update [-eh] [--per-module] [--refresh] [--[no-]registry-client]
[--verbose] [--config=CONFIG] [-D=<String=String>]...
[-S=targetStreamId | -P=targetPlatformVersion | -L]
Options:
[...]
Target Quarkus version:
-S, --stream-id=targetStreamId
A target stream id, for example:
2.0
-P, --platform-version=targetPlatformVersion
A specific target Quarkus platform version, for example:
2.2.0.Final
-L, --latest Use the latest Quarkus platform version |
a6dc474
to
d68bd60
Compare
This comment has been minimized.
This comment has been minimized.
I still don't like the |
d68bd60
to
3970de4
Compare
How about --stream to indicate stay within the stream you are in ? |
25aaec9
to
5f60444
Compare
This comment has been minimized.
This comment has been minimized.
2139b22
to
65c0ff2
Compare
This comment has been minimized.
This comment has been minimized.
786b40e
to
4975c55
Compare
This comment has been minimized.
This comment has been minimized.
4975c55
to
86b5450
Compare
This comment has been minimized.
This comment has been minimized.
86b5450
to
6d39c9b
Compare
6d39c9b
to
7b0b722
Compare
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
part of #29000
Allow to:
"io.quarkus:quarkus-update-recipes:LATEST
Prepare the tooling update/info commands as discussed on Zulip:
quarkus info
should:quarkus update -V [current-quarkus-version]
quarkus update
should: Suggest recommended project updates with the possibility to apply them.quarkus -V --version
: version of the CLI (not project related),quarkus version
: hide and forward to quarkus -VI've added the recipe generation to the update command, we still need to:
TODO ALEXEY: