Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test OpenTelemetry OTLP Exporter proxy #1834

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Test OpenTelemetry OTLP Exporter proxy #1834

merged 1 commit into from
Jun 13, 2024

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 11, 2024 •
edited
Loading

Summary

test coverage for quarkusio/quarkus#39519

TP: quarkus-qe/quarkus-test-plans#178

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/add-otel-proxy-test-coverage branch 2 times, most recently from 19dfdf8 to 2a2fa8f Compare June 11, 2024 19:09
@michalvavrik michalvavrik force-pushed the feature/add-otel-proxy-test-coverage branch from 2a2fa8f to a03ca8d Compare June 11, 2024 21:47
@michalvavrik michalvavrik requested a review from jcarranzan June 11, 2024 22:49
jcarranzan
jcarranzan reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@jcarranzan jcarranzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According your TP, is there also Proxy enabled / disabled during the runtime test?

@michalvavrik
Copy link
Member Author

According your TP, is there also Proxy enabled / disabled during the runtime test?

here it is enabled, while disabled is everywhere else; I am happy to test something on disabled proxy if you have an idea, what should I test? I could set proxy options that are going to be ignored if you want

@jcarranzan
Copy link
Contributor

According your TP, is there also Proxy enabled / disabled during the runtime test?

here it is enabled, while disabled is everywhere else; I am happy to test something on disabled proxy if you have an idea, what should I test? I could set proxy options that are going to be ignored if you want

According your TP, is there also Proxy enabled / disabled during the runtime test?

here it is enabled, while disabled is everywhere else; I am happy to test something on disabled proxy if you have an idea, what should I test? I could set proxy options that are going to be ignored if you want

It is not needed, thanks. IMHO this is quite enough for our testing coverage purpose.

@michalvavrik
Copy link
Member Author

It is not needed, thanks. IMHO this is quite enough for our testing coverage purpose.

Thanks. I will add one little check that proxy enablement flag works.

@michalvavrik michalvavrik force-pushed the feature/add-otel-proxy-test-coverage branch from a03ca8d to 90f4e21 Compare June 12, 2024 15:00
@michalvavrik michalvavrik requested a review from jcarranzan June 12, 2024 15:02
jcarranzan
jcarranzan approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jcarranzan jcarranzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!.

@jcarranzan jcarranzan merged commit f5c3920 into quarkus-qe:main Jun 13, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/add-otel-proxy-test-coverage branch June 13, 2024 11:06
jedla97 pushed a commit to jedla97/quarkus-test-suite that referenced this pull request Jun 20, 2024
@michalvavrik @jedla97
Test OpenTelemetry OTLP Exporter proxy (quarkus-qe#1834)
dc02955
@jedla97 jedla97 mentioned this pull request Jun 20, 2024
Merged
9 tasks
jedla97 pushed a commit to jedla97/quarkus-test-suite that referenced this pull request Jun 20, 2024
@michalvavrik @jedla97
Test OpenTelemetry OTLP Exporter proxy (quarkus-qe#1834)
307a66f 
(cherry picked from commit f5c3920)
@jedla97 jedla97 added this to the 2.7 milestone Jun 20, 2024
@jedla97 jedla97 removed this from the 2.7 milestone Jun 20, 2024
gtroitsk pushed a commit that referenced this pull request Jun 21, 2024
@jedla97 @michalvavrik
@jcarranzan @fedinskiy
[3.8] Backport for 3.8 branch 20.6.2024 (#1849)
a271ae3 
* Test OpenTelemetry OTLP Exporter proxy (#1834)

(cherry picked from commit f5c3920)

* Add test coverage for QUARKUS-4430

(cherry picked from commit 040144f)

* QQE-673 | Cover max-length option for syslog logs

Adds new module for working with syslogs, since jboss uses json logs
which have less predictable size.
Uses official image pof sylog-ng. Syslog-ng was chose over rsyslog and
logstash because it supports syslog input and stdout output out of the
box, without additional plugins.

Required for https://issues.redhat.com/browse/QUARKUS-4531

(cherry picked from commit 36a1dd9)

---------

Co-authored-by: Michal Vavřík <[email protected]>
Co-authored-by: jcarranzan <[email protected]>
Co-authored-by: Fedor Dudinsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarranzan jcarranzan jcarranzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @jcarranzan @jedla97