Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Backport for 3.8 branch 20.6.2024 #1849

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Jun 20, 2024

Summary

Backport of:

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97
Copy link
Member Author

jedla97 commented Jun 20, 2024

run tests

@rsvoboda
Copy link
Member

It seems https://github.com/quarkusio/quarkus-backports app wasn't used to help to prepare this backport

Symptoms:

michalvavrik and others added 3 commits June 20, 2024 16:43
(cherry picked from commit 040144f)
Adds new module for working with syslogs, since jboss uses json logs
which have less predictable size.
Uses official image pof sylog-ng. Syslog-ng was chose over rsyslog and
logstash because it supports syslog input and stdout output out of the
box, without additional plugins.

Required for https://issues.redhat.com/browse/QUARKUS-4531

(cherry picked from commit 36a1dd9)
@jedla97
Copy link
Member Author

jedla97 commented Jun 20, 2024

@rsvoboda Thanks I didn't know about this tool. Only problem with our repo is that we not using milestone so the 2.7 need to be used and after marking it as done in app the milestone from issue need to be removed.

@rsvoboda
Copy link
Member

We can create 3.8 milestone, we own the repo ...

@jedla97
Copy link
Member Author

jedla97 commented Jun 20, 2024

run tests

@jedla97 jedla97 requested a review from gtroitsk June 21, 2024 07:05
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtroitsk gtroitsk merged commit a271ae3 into quarkus-qe:3.8 Jun 21, 2024
9 checks passed
@jedla97 jedla97 deleted the 3.8-backport branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants