QQE-673 | Cover max-length option for syslog logs #1839
Merged
+181
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fedinskiy please link TP |
logging/thirdparty/src/test/java/io/quarkus/ts/logging/jboss/SyslogIT.java
Outdated
Show resolved
Hide resolved
fedinskiy
force-pushed
the
feature/syslog-max-length
branch
from
00da183 to
baf13f6
Compare
|
This is a coverage for a single issue[1], so there is no TP. The new module was added only because we do not have a proper catch-all logging module |
logging/thirdparty/src/test/java/io/quarkus/ts/logging/jboss/SyslogIT.java
Show resolved
Hide resolved
logging/thirdparty/src/test/java/io/quarkus/ts/logging/jboss/SyslogIT.java
Show resolved
Hide resolved
I can see that ticket is feature https://issues.redhat.com/browse/QUARKUS-4531, that's why I asked for the TP. Personally I don't mind, let's not create TP just because of me. Changes LGTM. |
fedinskiy
force-pushed
the
feature/syslog-max-length
branch
from
baf13f6 to
983d9e5
Compare
|
FYI @fedinskiy validation fails |
Adds new module for working with syslogs, since jboss uses json logs which have less predictable size. Uses official image pof sylog-ng. Syslog-ng was chose over rsyslog and logstash because it supports syslog input and stdout output out of the box, without additional plugins. Required for https://issues.redhat.com/browse/QUARKUS-4531
fedinskiy
force-pushed
the
feature/syslog-max-length
branch
from
983d9e5 to
36a1dd9
Compare
|
|
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new module for working with syslogs, since jboss uses json logs which have less predictable size.
Uses official image of sylog-ng. Syslog-ng was chose over rsyslog and logstash because it supports syslog input and stdout output out of the box, without additional plugins.
Required for https://issues.redhat.com/browse/QUARKUS-4531
Summary
(Summarize the problem solved by this PR, and how to verify it manually)
Please select the relevant options.
run testsphrase in comment)Checklist: