Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests and packages #675

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

michalvavrik
Copy link
Member

Summary

As part of Test Suite clean up couple of tests were renamed to self-explanatory names and packages renames to packages unique for each module.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from pjgg June 1, 2022 22:17
@michalvavrik michalvavrik self-assigned this Jun 1, 2022
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, just a minor suggestion!

@michalvavrik michalvavrik force-pushed the feature/rename-tests branch from 9f53f06 to 3298c5b Compare June 2, 2022 10:16
As part of Test Suite clean up couple of tests were renamed to self-explanatory names and packages renames to packages unique for each module.
@michalvavrik michalvavrik force-pushed the feature/rename-tests branch from 3298c5b to 6da9c1b Compare June 2, 2022 10:43
@michalvavrik michalvavrik requested a review from pjgg June 2, 2022 13:18
@michalvavrik michalvavrik added the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 2, 2022
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit 0e0d400 into quarkus-qe:main Jun 2, 2022
@michalvavrik michalvavrik deleted the feature/rename-tests branch June 2, 2022 14:53
@pjgg pjgg mentioned this pull request Jun 6, 2022
2 tasks
@pjgg pjgg added this to the 2.7 milestone Jun 8, 2022
@pjgg pjgg removed the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants