-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.7] Bulk - Backport from upstream _1 #688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7f6eb16)
(cherry picked from commit 57b2c12)
We should use latest Keycloak version. Upstream docs says `In Keycloak 17 the default distribution is now powered by Quarkus, while the legacy WildFly powered distribution will still be around until June 2022 we highly recommend starting the migration as soon as possible.` Using Keycloak 13.0.1 caused test failures of DevModeKeycloakDevServiceUserExperienceIT (cherry picked from commit bf98e05)
Tracing operation name is registered as `/graphql` and but the test used operation name `graphql`, thus no tracing were found and the test failed. (cherry picked from commit 2495b93)
We expected Content-Type header to contain only "application/json". But it can(and now does) contain other things, namely "charset" and "boundary" fields[1]. Therefore, we need to fix our tests. [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type (cherry picked from commit 63bb053)
…plication (cherry picked from commit c90514b)
(cherry picked from commit 8384e8f)
(cherry picked from commit f562a18)
As part of Test Suite clean up couple of tests were renamed to self-explanatory names and packages renames to packages unique for each module. (cherry picked from commit 6da9c1b)
Follow up to [PR 655](quarkus-qe#655). Enable `urPathTemplate` by default and provide mechanism to disable respective resource and test in Quarkus version lesser then 2.8.3 . `quarkus.index-dependency.resteasy-multipart` comment is updated according to the refactored state. (cherry picked from commit 6a0cefa)
(cherry picked from commit b10582a)
(cherry picked from commit 61e59ed)
Verifies [Quarkus Issue 24800](quarkusio/quarkus#24800). Calling repository methods returning interface-based projection defined outside of `PanacheRepository` causes a runtime exception. The issue was fixed in Quarkus 2.8.1 and backported to 2.7.6. The issue can be reproduced by commenting out `@DisabledOnQuarkusVersion` on the test and running `mvn clean verify -Dit.test=SpringDataBookResourceIT#testInterfaceBasedProjection -Dquarkus.platform.version=2.7.5.Final`. (cherry picked from commit 9e00ddc)
TD for quarkusio/quarkus#25184 (cherry picked from commit b710a32)
Verifies [Quarkus Issue 24344](quarkusio/quarkus#24344). Test class annotated with `javax.ws.rs.Path` and registered as client via `org.eclipse.microprofile.rest.client.inject.RegisterRestClient` must not be included in OpenAPI Document. (cherry picked from commit 1b526c8)
(cherry picked from commit 61a0a93)
Covers reported bug: quarkusio/quarkus#25029. (cherry picked from commit 67141e7)
Verifies [Quarkus Issue 22119](quarkusio/quarkus#22119). According to JAX-RS standard, if request specifies accepted Media type, the type should be passed to `javax.ws.rs.ext.MessageBodyWriter`, however for use case when `javax.ws.rs.core.Response` is returned, that was only fixed in Quarkus 2.8.1 and backported to 2.7.6. Previously, if multiple media types were defined in `@Produces`, the first one was taken. This test verifies that a value of `Accept` HTTP header is same as the media type passed to `MessageBodyWriter` when endpoint response type is `Response`. (cherry picked from commit 7f245d1)
(cherry picked from commit 1f9cd08)
pjgg
commented
Jun 7, 2022
...src/test/java/io/quarkus/ts/security/keycloak/DevModeKeycloakDevServiceUserExperienceIT.java
Show resolved
Hide resolved
michalvavrik
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
security/jwt
in order to use JWT builder inside a Quarkus applicationHttpAdvancedReactiveIT#uriPathTemplate
in Github workflowsChecklist: