Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Bulk - Backport from upstream _1 #688

Merged
merged 23 commits into from
Jun 7, 2022

Conversation

michalvavrik and others added 19 commits June 6, 2022 22:20
(cherry picked from commit 7f6eb16)
We should use latest Keycloak version. Upstream docs says `In Keycloak 17 the default distribution is now powered by Quarkus,
while the legacy WildFly powered distribution will still be around until
 June 2022 we highly recommend starting the migration as soon as
possible.` Using Keycloak 13.0.1 caused test failures of DevModeKeycloakDevServiceUserExperienceIT

(cherry picked from commit bf98e05)
Tracing operation name is registered as `/graphql` and but the test used operation name `graphql`, thus no tracing were found and the test failed.

(cherry picked from commit 2495b93)
We expected Content-Type header to contain only "application/json".
But it can(and now does) contain other things,
namely "charset" and "boundary" fields[1].
Therefore, we need to fix our tests.

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type

(cherry picked from commit 63bb053)
(cherry picked from commit 8384e8f)
(cherry picked from commit f562a18)
As part of Test Suite clean up couple of tests were renamed to self-explanatory names and packages renames to packages unique for each module.

(cherry picked from commit 6da9c1b)
Follow up to [PR 655](quarkus-qe#655). Enable `urPathTemplate` by default and provide mechanism to disable respective resource and test in Quarkus version lesser then 2.8.3 . `quarkus.index-dependency.resteasy-multipart` comment is updated according to the refactored state.

(cherry picked from commit 6a0cefa)
(cherry picked from commit b10582a)
Verifies [Quarkus Issue 24800](quarkusio/quarkus#24800). Calling repository methods returning interface-based projection defined outside of `PanacheRepository` causes a runtime exception. The issue was fixed in Quarkus 2.8.1 and backported to 2.7.6. The issue can be reproduced by commenting out `@DisabledOnQuarkusVersion` on the test and running `mvn clean verify -Dit.test=SpringDataBookResourceIT#testInterfaceBasedProjection -Dquarkus.platform.version=2.7.5.Final`.

(cherry picked from commit 9e00ddc)
Verifies [Quarkus Issue 24344](quarkusio/quarkus#24344). Test class annotated with `javax.ws.rs.Path` and registered as client via `org.eclipse.microprofile.rest.client.inject.RegisterRestClient` must not be included in OpenAPI Document.

(cherry picked from commit 1b526c8)
(cherry picked from commit 61a0a93)
Covers reported bug: quarkusio/quarkus#25029.

(cherry picked from commit 67141e7)
Verifies [Quarkus Issue 22119](quarkusio/quarkus#22119). According to JAX-RS standard, if request specifies accepted Media type, the type should be passed to `javax.ws.rs.ext.MessageBodyWriter`, however for use case when `javax.ws.rs.core.Response` is returned, that was only fixed in Quarkus 2.8.1 and backported to 2.7.6. Previously, if multiple media types were defined in `@Produces`, the first one was taken. This test verifies that a value of `Accept` HTTP header is same as the media type passed to `MessageBodyWriter` when endpoint response type is `Response`.

(cherry picked from commit 7f245d1)
@pjgg pjgg requested a review from michalvavrik June 6, 2022 20:28
@pjgg pjgg changed the title [2.7] Bulk - Backport from upstream [2.7] Bulk - Backport from upstream _1 Jun 6, 2022
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit fc66b29 into quarkus-qe:2.7 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants