Handle paths with a '?' in them #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Feb 15, 2022
|
Out of curiosity, in what cases can a path pointing to a jar contain question marks? Any examples? |
|
Just make a directory with a question mark in the name on Linux (won't work on windows). |
|
Perhaps skip the test on Windows? |
This is actually quite tricky, as URI does not let you create these by default, you need to sneak them in using URL.toUrl(). If you attempt to use the URI constructor directly then a '?' is interpreted as the start of the query string, and %3f is encoded to %253f, so there is no way to actually pass in an ecoded question mark to the URI constructor.
stuartwdouglas
force-pushed
the
question-mark
branch
from
dbc42a3 to
ed472ac
Compare
|
Oops, I already had that locally but just forgot to push it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually quite tricky, as URI does not let you create these by
default, you need to sneak them in using URL.toUrl(). If you attempt to
use the URI constructor directly then a '?' is interpreted as the start
of the query string, and %3f is encoded to %253f, so there is no way to
actually pass in an ecoded question mark to the URI constructor.