Handle paths with a question mark in them #23696

stuartwdouglas · 2022-02-15T01:08:53Z

This needs quarkusio/quarkus-fs-util#14 to be merged and 0.0.9 to be released.

quarkus-bot · 2022-02-15T01:10:54Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `5d19b1f`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/bootstrap/app-model 
! Skipped: core/deployment core/launcher core/runtime and 699 more

📦 independent-projects/bootstrap/app-model

✖ Failed to execute goal on project quarkus-bootstrap-app-model: Could not resolve dependencies for project io.quarkus:quarkus-bootstrap-app-model:jar:999-SNAPSHOT: Could not find artifact io.quarkus:quarkus-fs-util:jar:0.0.9 in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

gastaldi · 2022-02-15T01:45:05Z

.../src/test/java/io/quarkus/bootstrap/classloader/ClassLoadingPathTreeResourceUrlTestCase.java

+        final JavaArchive jar = ShrinkWrap.create(JavaArchive.class)
+                .add(new StringAsset("a"), "a.txt")
+                .add(new StringAsset("b"), "b/b.txt");
+        final Path tmpDir = Files.createTempDirectory("test?");


Isn't ? illegal in Windows?

Yes, just confirmed that this test will fail in Windows

quarkus-bot · 2022-02-15T02:37:09Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `e149e9e`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/bootstrap/app-model 
! Skipped: core/deployment core/launcher core/runtime and 699 more

📦 independent-projects/bootstrap/app-model

✖ Failed to execute goal on project quarkus-bootstrap-app-model: Could not resolve dependencies for project io.quarkus:quarkus-bootstrap-app-model:jar:999-SNAPSHOT: Could not find artifact io.quarkus:quarkus-fs-util:jar:0.0.9 in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

quarkus-bot · 2022-02-15T02:43:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `fc559d3`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/bootstrap/app-model 
! Skipped: core/deployment core/launcher core/runtime and 699 more

📦 independent-projects/bootstrap/app-model

✖ Failed to execute goal on project quarkus-bootstrap-app-model: Could not resolve dependencies for project io.quarkus:quarkus-bootstrap-app-model:jar:999-SNAPSHOT: Could not find artifact io.quarkus:quarkus-fs-util:jar:0.0.9 in google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/)

aloubyansky · 2022-02-15T10:05:28Z

I restarted the CI

aloubyansky · 2022-02-15T13:11:53Z

Failure on Windows

2022-02-15T10:33:41.8008350Z [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.1 s <<< FAILURE! - in io.quarkus.bootstrap.classloader.ClassLoadingResourceUrlTestCase
2022-02-15T10:33:41.8281692Z [ERROR] io.quarkus.bootstrap.classloader.ClassLoadingResourceUrlTestCase.testUrlReturnedFromClassLoaderDirectory(String)[1]  Time elapsed: 0.02 s  <<< ERROR!
2022-02-15T10:33:41.8283828Z java.nio.file.InvalidPathException: Illegal char <?> at index 4: test?15515974475056451777
2022-02-15T10:33:41.8284596Z 	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
2022-02-15T10:33:41.8285236Z 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
2022-02-15T10:33:41.8287601Z 	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
2022-02-15T10:33:41.8288209Z 	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
2022-02-15T10:33:41.8288768Z 	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229)
2022-02-15T10:33:41.8289612Z 	at java.base/java.nio.file.TempFileHelper.generatePath(TempFileHelper.java:59)
2022-02-15T10:33:41.8290205Z 	at java.base/java.nio.file.TempFileHelper.create(TempFileHelper.java:126)
2022-02-15T10:33:41.8290826Z 	at java.base/java.nio.file.TempFileHelper.createTempDirectory(TempFileHelper.java:172)
2022-02-15T10:33:41.8291433Z 	at java.base/java.nio.file.Files.createTempDirectory(Files.java:1007)
2022-02-15T10:33:41.8292391Z 	at io.quarkus.bootstrap.classloader.ClassLoadingResourceUrlTestCase.testUrlReturnedFromClassLoaderDirectory(ClassLoadingResourceUrlTestCase.java:39)

quarkus-bot · 2022-02-15T14:11:39Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `fc559d3`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: independent-projects/bootstrap/core 
! Skipped: core/deployment core/launcher core/runtime and 671 more

📦 independent-projects/bootstrap/core

✖ io.quarkus.bootstrap.classloader.ClassLoadingResourceUrlTestCase.testUrlReturnedFromClassLoaderDirectory(String)[1] line 39 - More details - Source on GitHub

java.nio.file.InvalidPathException: Illegal char <?> at index 4: test?15515974475056451777
	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)

quarkus-bot · 2022-02-16T00:17:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b627bb7`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/reactive-routes/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 164 more

📦 extensions/reactive-routes/deployment

✖ io.quarkus.vertx.web.context.DuplicatedContextTest.testThatBlockingRoutesAreCalledOnDuplicatedContext line 63 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/reactive-routes/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 164 more

📦 extensions/reactive-routes/deployment

✖ io.quarkus.vertx.web.context.DuplicatedContextTest.testThatBlockingRoutesAreCalledOnDuplicatedContext line 63 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:283)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:309)

famod · 2022-02-16T23:22:59Z

This needs a rebase to receive the latest flaky test fixes.

quarkus-bot · 2022-02-17T00:25:52Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `07bb261`

Status	Name	Step	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Devtools Tests - JDK 17	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 17	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Maven Tests - JDK 11	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Maven Tests - JDK 11 Windows	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	MicroProfile TCKs Tests	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - AWT, ImageIO and Java2D	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Amazon	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Cache	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data3	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data4	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data5	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data6	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Data7	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - DevTools Integration Tests	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - HTTP	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Main	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Messaging1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Messaging2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc3	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Misc4	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security1	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security2	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Security3	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Spring	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - Windows - RESTEasy Jackson	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs
✖	Native Tests - gRPC	`Extract Maven Repo`	⚠️ Check →	Logs	Raw logs

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Feb 15, 2022

gastaldi approved these changes Feb 15, 2022

View reviewed changes

gastaldi reviewed Feb 15, 2022

View reviewed changes

stuartwdouglas force-pushed the question-mark-in-path branch from 5d19b1f to e149e9e Compare February 15, 2022 02:34

stuartwdouglas force-pushed the question-mark-in-path branch from e149e9e to fc559d3 Compare February 15, 2022 02:40

geoand requested a review from aloubyansky February 15, 2022 06:25

aloubyansky approved these changes Feb 15, 2022

View reviewed changes

aloubyansky added the triage/backport? label Feb 15, 2022

stuartwdouglas force-pushed the question-mark-in-path branch from fc559d3 to b627bb7 Compare February 15, 2022 20:02

famod added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 16, 2022

Handle paths with a question mark in them

07bb261

stuartwdouglas force-pushed the question-mark-in-path branch from b627bb7 to 07bb261 Compare February 16, 2022 23:54

famod removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 16, 2022

geoand merged commit 7dbf71d into quarkusio:main Feb 17, 2022

quarkus-bot bot added this to the 2.8 - main milestone Feb 17, 2022

gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022

gsmet removed the triage/backport? label Feb 21, 2022

Handle paths with a question mark in them #23696

Handle paths with a question mark in them #23696

Conversation

stuartwdouglas commented Feb 15, 2022

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building 5d19b1f

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/bootstrap/app-model

gastaldi Feb 15, 2022

Choose a reason for hiding this comment

gastaldi Feb 15, 2022

Choose a reason for hiding this comment

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building e149e9e

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/bootstrap/app-model

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building fc559d3

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/bootstrap/app-model

aloubyansky commented Feb 15, 2022

aloubyansky commented Feb 15, 2022

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building fc559d3

Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/bootstrap/core

quarkus-bot bot commented Feb 16, 2022 • edited Loading

Failing Jobs - Building b627bb7

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 11 #

📦 extensions/reactive-routes/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/reactive-routes/deployment

famod commented Feb 16, 2022

quarkus-bot bot commented Feb 17, 2022 • edited Loading

Failing Jobs - Building 07bb261

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `5d19b1f`

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `e149e9e`

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `fc559d3`

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `fc559d3`

quarkus-bot bot commented Feb 16, 2022 •

edited

Loading

Failing Jobs - Building `b627bb7`

quarkus-bot bot commented Feb 17, 2022 •

edited

Loading

Failing Jobs - Building `07bb261`