Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] bump version to 0.13.0 also for Gradle #137

Closed
wants to merge 1 commit into from

Conversation

vorburger
Copy link
Contributor

see #136

@vorburger
Copy link
Contributor Author

@gsmet @cescoffier @stalep

@gsmet
Copy link
Member

gsmet commented Apr 8, 2019

@cescoffier any chance you could take a look at automating it soon? I suspect we will have to release a 0.13.1 soon, considering the potential bootstrap issue we have.

@vorburger
Copy link
Contributor Author

vorburger commented Apr 8, 2019

@cescoffier I suspect you'll probably want to merge this (manual) PR already anyway (because it doesn't just bump versions but also fixes IDs, which should be a one time thing), and THEN in #136 fix whatever script does the automated version bumps to do what I did manually here automatically (but simpler, forget about the IDs, just bump the version numbers).

@cescoffier
Copy link
Member

I don't know much Gradle, I fear it will end up with an error-prone sed / awk kind of thing (like https://stackoverflow.com/questions/42044160/gradle-equivalent-of-maven-versions-plugin).

@cescoffier
Copy link
Member

Looking at the gradle files right now, it must be refactored to avoid duplicating the versions:

plugins {
    id 'java'
    id 'io.quarkus.gradle.plugin' version '0.12.0' . <--- occurence 1
}

repositories {
     mavenCentral()
     maven { url 'http://repository.jboss.org/nexus/content/groups/public' }
}

dependencies {
    implementation group: 'io.quarkus', name: 'quarkus-resteasy', version:'0.12.0' <-- occurence 2

    testCompile group: 'io.quarkus', name: 'quarkus-junit5', version:'0.12.0' <-- occurence 3
    testCompile group: 'io.rest-assured', name: 'rest-assured', version: '3.3.0'
}

Can someone with gradle experience update the gradle files to use a single variable with a coherent name (so sed / awk magic can work).

@gsmet
Copy link
Member

gsmet commented Apr 9, 2019

Closing this one, we don't want to apply anything like that to master and have conflicts right away.

I'll extract the important bits of it and try to come with a scripted approach for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants