Merge pull request #4897 from jaikiran/fix-native-image-options

Don't add the "--rm" option to "docker run" command, of native-image, too early
quarkusio · Oct 27, 2019 · 69ade9d · 69ade9d
2 parents 41376b1 + 97e26a2
commit 69ade9d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
@@ -82,7 +82,7 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa
             // E.g. "/usr/bin/docker run -v {{PROJECT_DIR}}:/project --rm quarkus/graalvm-native-image"
             nativeImage = new ArrayList<>();
             Collections.addAll(nativeImage, nativeConfig.containerRuntime, "run", "-v",
-                    outputDir.toAbsolutePath() + ":/project:z", "--rm");
+                    outputDir.toAbsolutePath() + ":/project:z");
 
             if (IS_LINUX) {
                 if ("docker".equals(nativeConfig.containerRuntime)) {
@@ -101,7 +101,7 @@ public NativeImageBuildItem build(NativeConfig nativeConfig, NativeImageSourceJa
                 // publish the debug port onto the host if asked for
                 nativeImage.add("--publish=" + DEBUG_BUILD_PROCESS_PORT + ":" + DEBUG_BUILD_PROCESS_PORT);
             }
-            nativeImage.add(nativeConfig.builderImage);
+            Collections.addAll(nativeImage, "--rm", nativeConfig.builderImage);
         } else {
             if (IS_LINUX) {
                 noPIE = detectNoPIE();