Don't add the "--rm" option to "docker run" command, of native-image, too early #4897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit here fixes an issue where the
--rm
option todocker run
command during native image generation, is added too early. This causes issues when the native image is passed addtionalcontainerRuntimeOptions
for example the below one:This ends up generating a command of the form:
notice that after
--rm
, the additional container runtime option(s) get added instead of the image name.This commit fixes that issue and the above command now gets correctly created as: