Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP headers in Spring Cloud Config Client extension #12099

Closed
briansterle opened this issue Sep 14, 2020 · 1 comment · Fixed by #12108
Closed

Add support for HTTP headers in Spring Cloud Config Client extension #12099

briansterle opened this issue Sep 14, 2020 · 1 comment · Fixed by #12108
Assignees
Labels
area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Milestone

Comments

@briansterle
Copy link

briansterle commented Sep 14, 2020

Description
The feature request is to add a new configuration property to support generic HTTP headers that would be used on the HTTP requests from the Spring Cloud config client to the Spring config server. This could be used to pass JWT credentials in an Authorization header, for example.

This is currently part of Spring's own config client implementation, accessible through the following property:
spring.cloud.config.headers

Implementation ideas
In Quarkus, the property name could be:
quarkus.spring-cloud-config.headers

taking a Map<String, String> type, as in the Spring implementation.

@briansterle briansterle added the kind/enhancement New feature or request label Sep 14, 2020
@quarkusbot quarkusbot added the area/spring Issues relating to the Spring integration label Sep 14, 2020
@quarkusbot
Copy link

/cc @geoand

@geoand geoand self-assigned this Sep 15, 2020
geoand added a commit to geoand/quarkus that referenced this issue Sep 15, 2020
geoand added a commit to geoand/quarkus that referenced this issue Sep 15, 2020
geoand added a commit that referenced this issue Sep 16, 2020
Add support for passing custom headers in Spring Cloud Config
@gsmet gsmet added this to the 1.9.0 - master milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants