Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for passing custom headers in Spring Cloud Config #12108

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Add support for passing custom headers in Spring Cloud Config #12108

merged 2 commits into from
Sep 16, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 15, 2020

Fixes: #12099

The first commit fixes bootstrap config in order to enable Map support for that Config.

@geoand
Copy link
Contributor Author

geoand commented Sep 15, 2020 •
edited
Loading

I would like a review from @dmlloyd on the first commit and @gastaldi or @gsmet for the second one.

Thanks!

@geoand geoand added this to the 1.9.0 - master milestone Sep 15, 2020
@geoand geoand added area/config area/spring Issues relating to the Spring integration labels Sep 15, 2020
gastaldi
gastaldi approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the headers are just being used to send to Spring Cloud so it doesn't matter if they are multiple or not

@geoand
Copy link
Contributor Author

geoand commented Sep 16, 2020

@dmlloyd mind taking a quick look at the first commit please?

Thanks

@dmlloyd
Copy link
Member

dmlloyd commented Sep 16, 2020

First commit seems OK to me.

@geoand geoand merged commit f32b078 into quarkusio:master Sep 16, 2020
@geoand geoand deleted the #12099 branch September 16, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/config area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Add support for HTTP headers in Spring Cloud Config Client extension
3 participants
@geoand @dmlloyd @gastaldi