Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@RedisClientName can't be applied to parameters #12898

Closed
xtaixe opened this issue Oct 23, 2020 · 4 comments · Fixed by #12902
Closed

@RedisClientName can't be applied to parameters #12898

xtaixe opened this issue Oct 23, 2020 · 4 comments · Fixed by #12902
Assignees
@machi1990
Labels
area/redis kind/bug Something isn't working
Milestone
1.10.0.CR1

Comments

@xtaixe
Copy link

xtaixe commented Oct 23, 2020

@RedisClientName can't be applied to parameters and thus named redis clients can't be injected to constructors or producer methods.
@xtaixe xtaixe added the kind/bug Something isn't working label Oct 23, 2020
@quarkusbot
Copy link

/cc @machi1990, @gsmet, @cescoffier

machi1990 added a commit to machi1990/quarkus that referenced this issue Oct 23, 2020
@machi1990
fix(redis): @RedisClientName can't be applied to parameters
82bdb87 
Fixes quarkusio#12898
@machi1990 machi1990 mentioned this issue Oct 23, 2020
Merged
@machi1990
Copy link
Member

Upon a quick check I realized that it might be the case for the Mongo client too

quarkus/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/MongoClientName.java

Line 30 in 5b874da

@Target({ ElementType.TYPE, ElementType.METHOD, ElementType.FIELD })

/cc @geoand @loicmathieu @cescoffier

machi1990 added a commit to machi1990/quarkus that referenced this issue Oct 23, 2020
@machi1990
fix(redis): @RedisClientName can't be applied to parameters
0324dfc 
Fixes quarkusio#12898
@loicmathieu
Copy link
Contributor

@machi1990 would you provide a fix, or @geoand ?
If not, can you open an issue for MongoDB ?

@machi1990
Copy link
Member

@machi1990 would you provide a fix, or @geoand ?
If not, can you open an issue for MongoDB ?

Working on a fix.

machi1990 added a commit to machi1990/quarkus that referenced this issue Oct 23, 2020
@machi1990
fix(redis): @RedisClientName can't be applied to parameters
7459835 
Fixes quarkusio#12898
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machi1990 machi1990

Labels
area/redis kind/bug Something isn't working
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging a pull request may close this issue.

Fix RedisClientName and MongoClientName can't be applied to parameters machi1990/quarkus
5 participants
@gsmet @loicmathieu @machi1990 @xtaixe @quarkusbot