Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RedisClientName and MongoClientName can't be applied to parameters #12902

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Fix RedisClientName and MongoClientName can't be applied to parameters #12902

merged 2 commits into from
Oct 24, 2020

Conversation

machi1990
Copy link
Member

Fixes #12898

@machi1990 machi1990 requested review from gsmet and cescoffier October 23, 2020 12:34
@machi1990
Copy link
Member Author

/cc @xtaixe can you check if this PR fixes your issue? You can follow these instructions https://github.com/quarkusio/quarkus/blob/master/CONTRIBUTING.md#checking-an-issue-is-fixed-in-master but do them against this PR and not the master branch. Thanks

gsmet
gsmet requested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And shouldn't we do exactly the same for MongoClientName? I think this one comes from there?

@machi1990
Copy link
Member Author

And shouldn't we do exactly the same for MongoClientName? I think this one comes from there?

Okay to do it for MongoClientName too. I wanted confirmation first here #12898 (comment). I can add a separate commit. WDYT? @gsmet

@gsmet
Copy link
Member

gsmet commented Oct 23, 2020

+1 for a separate commit. Let's add separate tests for both to be sure.

@machi1990 machi1990 changed the title fix(redis): @RedisClientName can't be applied to parameters Fix RedisClientName and MongoClientName can't be applied to parameters Oct 23, 2020
@machi1990 machi1990 requested review from gsmet and cescoffier October 23, 2020 13:30
@machi1990
Copy link
Member Author

+1 for a separate commit. Let's add separate tests for both to be sure.

@gsmet suggestions applied. Let me know what you think.

@gsmet gsmet merged commit 8840799 into quarkusio:master Oct 24, 2020
@machi1990 machi1990 deleted the fix/12898 branch October 24, 2020 12:22
@xtaixe
Copy link

xtaixe commented Oct 26, 2020

@machi1990 tested redis (with SNAPSHOT, since it's already merged). Worked fine. Thanks.

@machi1990
Copy link
Member Author

@xtaixe thanks for verification.

@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
@gsmet
Copy link
Member

gsmet commented Oct 27, 2020

I haven't backported this one given too many conflicts.

Once again, better not fiddle with existing tests as it makes backporting a nightmare.

@machi1990
Copy link
Member Author

I haven't backported this one given too many conflicts.

Ah I think it's the Mongo related tests that might have caused an issue since I noticed some duplication and decided to deal with them.

Once again, better not fiddle with existing tests as it makes backporting a nightmare.

Noted. Sorry for the nightmare.

@jsmrcka jsmrcka mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

@cescoffier cescoffier cescoffier approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging this pull request may close these issues.

@RedisClientName can't be applied to parameters
5 participants
@machi1990 @gsmet @xtaixe @cescoffier @mkouba