Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevMojoIT.testThatNewResourcesAreServed is flaky #16524

Closed
famod opened this issue Apr 14, 2021 · 11 comments · Fixed by #16527
Closed

DevMojoIT.testThatNewResourcesAreServed is flaky #16524

famod opened this issue Apr 14, 2021 · 11 comments · Fixed by #16527
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@famod
Copy link
Member

famod commented Apr 14, 2021

Seen e.g. here and here:

2021-04-14 15:57:25,403 INFO  [io.quarkus] (Quarkus Main Thread) acme 1.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 0.304s. Listening on: http://localhost:8080
2021-04-14 15:57:25,404 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2021-04-14 15:57:25,404 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, resteasy, smallrye-context-propagation, websockets]
2021-04-14 15:57:25,404 INFO  [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-3) Live reload total time: 0.388s 
Error:  Tests run: 40, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 553.529 s <<< FAILURE! - in io.quarkus.maven.it.DevMojoIT
Error:  io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed  Time elapsed: 72.101 s  <<< ERROR!
org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT that uses java.lang.String was not fulfilled within 1 minutes.
@famod famod added kind/bug Something isn't working area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Apr 14, 2021
@famod
Copy link
Member Author

famod commented Apr 14, 2021

/cc @aloubyansky @geoand

@geoand
Copy link
Contributor

geoand commented Apr 14, 2021

I have an idea what might be the cause of this issue

geoand added a commit to geoand/quarkus that referenced this issue Apr 14, 2021
@geoand
Ensure that Vert.x runs in its dev-mode when Quarkus is started in de…
d7551c4 
…v-mode

This prevents Vert.x from caching static resources

Fixes: quarkusio#16524
@geoand geoand mentioned this issue Apr 14, 2021
Merged
@geoand
Copy link
Contributor

geoand commented Apr 14, 2021 •
edited
Loading

#16527 should take care of the issue.

I used @RepeatedTest to run the test with the fix and it passed (as opposed to prior to the fix where I could easily reproduce the problem)

@famod
Copy link
Member Author

famod commented Apr 14, 2021

Good catch! But why did it not fail every time?

@geoand
Copy link
Contributor

geoand commented Apr 14, 2021

My assumption is that something changed with Vert.x - maybe it caches for longer.
I didn't look to closely at the implementation

@famod
Copy link
Member Author

famod commented Apr 14, 2021

Well, a fix is a fix.

geoand added a commit to geoand/quarkus that referenced this issue Apr 15, 2021
@geoand
Ensure that Vert.x runs in its dev-mode when Quarkus is started in de…
36f76f5 
…v-mode

This prevents Vert.x from caching static resources

Fixes: quarkusio#16524
geoand added a commit that referenced this issue Apr 15, 2021
@geoand
Merge pull request #16527 from geoand/#16524
dbed19f 
Ensure that Vert.x runs in its dev-mode when Quarkus is started in dev-mode
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 15, 2021
@famod
Copy link
Member Author

famod commented Apr 16, 2021 •
edited
Loading

Unfortunately, this still happens: #16250 (comment)

@famod famod reopened this Apr 16, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 26, 2021
@geoand @gsmet
Ensure that Vert.x runs in its dev-mode when Quarkus is started in de…
90c2fd5 
…v-mode

This prevents Vert.x from caching static resources

Fixes: quarkusio#16524
(cherry picked from commit 36f76f5)
@gsmet gsmet removed this from the 1.13.3.Final milestone Apr 28, 2021
@famod famod mentioned this issue May 8, 2021
Open
@famod
Copy link
Member Author

famod commented Jul 4, 2021

Haven't seen this for a while, closing.

@famod famod closed this as completed Jul 4, 2021
@geoand
Copy link
Contributor

geoand commented Jul 6, 2021 •
edited
Loading

Actually, I've see this happen, for example in #18363 (comment)

@geoand geoand reopened this Jul 6, 2021
@geoand
Copy link
Contributor

geoand commented Jul 6, 2021

The problem is that I cannot reproduce the problem locally...

geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2021
@geoand
Use matchers to in flaky DevMojoIT in order to get proper logs when t…
d93d210 
…he test fails

Relates to: quarkusio#16524
@geoand geoand mentioned this issue Jul 6, 2021
Merged
geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2021
@geoand
Use matchers to in flaky DevMojoIT in order to get proper logs when t…
1f1ddc0 
…he test fails

Relates to: quarkusio#16524
geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2021
@geoand
Use matchers to in flaky DevMojoIT in order to get proper logs when t…
51c50ee 
…he test fails

Relates to: quarkusio#16524
gsmet added a commit that referenced this issue Jul 6, 2021
@gsmet
Merge pull request #18437 from geoand/#16524
8d14845 
Use matchers to in flaky DevMojoIT in order to get proper logs when the test fails
@geoand
Copy link
Contributor

geoand commented Jan 25, 2022

Closing this as the test is no longer flaky.

@geoand geoand closed this as completed Jan 25, 2022
@geoand geoand added the triage/out-of-date This issue/PR is no longer valid or relevant label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that Vert.x runs in its dev-mode when Quarkus is started in dev-mode geoand/quarkus
3 participants
@gsmet @geoand @famod