Infinispan extension upgrades #18363

karesti · 2021-07-02T17:23:48Z

Upgrade to 12.1.6.Final
ISPN-13146 Improve the documentation and defaults
ISPN-12780 Protobuf schema registration property
ISPN-13137 Avoid creating the Remote cache without configuration

Resolves #18232

karesti · 2021-07-02T17:50:37Z

We need to upgrade to 12.1.6.Final, don't merge please (even if all test pass which I hope they do)

wburns

I will be on PTO for a while, so I can't follow up on a review until mid July. So it would be much appreciate if someone else can review after the changes and approve as necessary.

docs/src/main/asciidoc/infinispan-client.adoc

...ent/runtime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientProducer.java

...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java

quarkus-bot · 2021-07-02T21:20:29Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `cecc97d`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Native Tests - Security2	`Download Maven Repo`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:42:52Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `b245939`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:45:44Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `dd39f96`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Set up job`	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	`Set up job`	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:46:05Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `049dfbc`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:46:39Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `41a7e39`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Run actions/checkout@v2`	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:51:53Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `6bf0219`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T08:57:01Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `9828cdd`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T09:05:13Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `65c978e`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T09:15:38Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `6ea3a78`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T09:29:36Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `a08683d`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T09:30:28Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `937bf89`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Reclaim Disk Space`	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-03T10:54:30Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `1cc88eb`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Windows - hibernate-validator		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun line 58 - More details - Source on GitHub

quarkus-bot · 2021-07-03T14:40:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `e7c82c7`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Maven Tests - JDK 11	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub

karesti · 2021-07-06T07:37:52Z

@gsmet @geoand Will is PTO for two weeks but I addressed all his comments here. Anything else needed to merge?

...loyment/src/main/java/io/quarkus/infinispan/client/deployment/InfinispanClientProcessor.java

docs/src/main/asciidoc/infinispan-client.adoc

geoand

I added a couple of tiny comments

geoand · 2021-07-06T08:56:20Z

Please squash the commits when you are done :)

quarkus-bot · 2021-07-06T09:11:58Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `6a9dec4`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Devtools Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Gradle Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Maven Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Amazon		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Cache		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data1	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data2	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data3	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data4	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data5	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data6	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Data7	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - HTTP		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Main	`Build`	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Messaging2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security1		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security2		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Security3		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Spring		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Windows - hibernate-validator		⚠️ Check →	Logs	Raw logs
⌛	Native Tests - gRPC		⚠️ Check →	Logs	Raw logs

karesti · 2021-07-06T09:12:00Z

@geoand i added the changes @oraNod has done in another commit with documentation improvements

geoand · 2021-07-06T09:14:32Z

Cool

quarkus-bot · 2021-07-06T09:26:34Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `2f7352b`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

* Upgrade to 12.1.6.Final * ISPN-13146 Improve the documentation and defaults * ISPN-12780 Protobuf schema registration property * ISPN-13137 Avoid creating the Remote cache without configuration Co-authored-by: William Burns <[email protected]>

karesti · 2021-07-08T08:47:22Z

@geoand do we need something else to merge? will is coming back in 10 days and I addressed all his comments

geoand · 2021-07-08T08:49:29Z

Let's merge it, thanks!

jamesnetherton · 2021-07-08T09:02:44Z

Shall I create a follow up issue to #18232? It's not 100% fixed IMO.

#18232 (comment)

domiborges · 2021-07-08T13:49:21Z

docs/src/main/asciidoc/infinispan-client.adoc

+
+Add the following properties to connect to Infinispan Server:
+
+[source,properties]


Hi @karesti , I'm checking the updates and trying to follow the steps however I got into some trouble :)

When I used a sample hello project with this configuration I was able to open the console at http://127.0.1.1:11222/console/ and follow the https://infinispan.org/get-started/. There was just one little confusion between 127.0.1.1:11222 and localhost:11222. localhost:11222 didn't work.

Then I tried the same with the quickstart and I wasn't able to compile the quickstart and failed to connect to localhost/127.0.0.1:11222. I'm probably missing some information.

I noticed that the configuration in the quickstart is different from the one in this guide. Which one should I use?

I have limited knowledge about Quarkus and this is my first experience with Infinispan however I wanted to share this with you in case that some of it is relevant. Please let me know if you want me to share the errors I got with the infinispan-client-quickstart. I'm on zulip or gchat.

The configuration in the quickstart and the guide are the same now, I did a PR to remove the unnecessary default values and simplify the connection.
http://localhost:11222/console/welcome and http://127.0.0.1:11222/console/welcome are the same url that point to the local running infinispan server (with a container or downloading the server.
maybe you are missing a config in your hosts file?
thanks for trying the quickstart!

karesti · 2021-07-08T16:02:49Z

@jamesnetherton sorry I missed the past comment. please, create another follow up issue, I need to check with the team about protostuff and decide which is the best way here

jamesnetherton · 2021-07-09T06:23:03Z

Thanks @karesti, follow up issue is #18517.

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/infinispan Infinispan labels Jul 2, 2021

wburns reviewed Jul 2, 2021

View reviewed changes

karesti force-pushed the infinispan-guide-update branch from 6ea3a78 to a08683d Compare July 3, 2021 09:14

karesti force-pushed the infinispan-guide-update branch from a08683d to 937bf89 Compare July 3, 2021 09:28

karesti force-pushed the infinispan-guide-update branch from 937bf89 to 1cc88eb Compare July 3, 2021 09:29

karesti force-pushed the infinispan-guide-update branch from 1cc88eb to e7c82c7 Compare July 3, 2021 10:49

geoand mentioned this pull request Jul 6, 2021

DevMojoIT.testThatNewResourcesAreServed is flaky #16524

Closed

geoand reviewed Jul 6, 2021

View reviewed changes

...loyment/src/main/java/io/quarkus/infinispan/client/deployment/InfinispanClientProcessor.java Outdated Show resolved Hide resolved

geoand reviewed Jul 6, 2021

View reviewed changes

docs/src/main/asciidoc/infinispan-client.adoc Outdated Show resolved Hide resolved

geoand reviewed Jul 6, 2021

View reviewed changes

karesti force-pushed the infinispan-guide-update branch from 6a9dec4 to 2f7352b Compare July 6, 2021 09:09

geoand approved these changes Jul 6, 2021

View reviewed changes

Infinispan extension upgrades

987a373

* Upgrade to 12.1.6.Final * ISPN-13146 Improve the documentation and defaults * ISPN-12780 Protobuf schema registration property * ISPN-13137 Avoid creating the Remote cache without configuration Co-authored-by: William Burns <[email protected]>

karesti force-pushed the infinispan-guide-update branch from 2f7352b to 987a373 Compare July 6, 2021 12:46

geoand merged commit 02b9572 into quarkusio:main Jul 8, 2021

quarkus-bot bot added this to the 2.1 - main milestone Jul 8, 2021

karesti deleted the infinispan-guide-update branch July 8, 2021 08:50

jamesnetherton mentioned this pull request Jul 8, 2021

Do not produce Infinispan RemoteCacheManager if no Infinispan configuration is present - part 2 #18517

Closed

karesti mentioned this pull request Jul 8, 2021

Upgrades to Infinispan 12.1.6.Final and extension defaults improvements quarkusio/quarkus-quickstarts#899

Merged

7 tasks

domiborges reviewed Jul 8, 2021

View reviewed changes


		Add the following properties to connect to Infinispan Server:

		[source,properties]

Infinispan extension upgrades #18363

Infinispan extension upgrades #18363

Conversation

karesti commented Jul 2, 2021 • edited Loading

karesti commented Jul 2, 2021

wburns left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jul 2, 2021 • edited Loading

Failing Jobs - Building cecc97d

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building b245939

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building dd39f96

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 049dfbc

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 41a7e39

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 6bf0219

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 9828cdd

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 65c978e

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 6ea3a78

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building a08683d

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 937bf89

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building 1cc88eb

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

quarkus-bot bot commented Jul 3, 2021 • edited Loading

Failing Jobs - Building e7c82c7

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

karesti commented Jul 6, 2021 • edited Loading

geoand left a comment

Choose a reason for hiding this comment

geoand commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 • edited Loading

Failing Jobs - Building 6a9dec4

karesti commented Jul 6, 2021

geoand commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 • edited Loading

Failing Jobs - Building 2f7352b

karesti commented Jul 8, 2021

geoand commented Jul 8, 2021

jamesnetherton commented Jul 8, 2021

domiborges Jul 8, 2021

Choose a reason for hiding this comment

karesti Jul 8, 2021

Choose a reason for hiding this comment

karesti commented Jul 8, 2021

jamesnetherton commented Jul 9, 2021

karesti commented Jul 2, 2021 •

edited

Loading

quarkus-bot bot commented Jul 2, 2021 •

edited

Loading

Failing Jobs - Building `cecc97d`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `b245939`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `dd39f96`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `049dfbc`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `41a7e39`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `6bf0219`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `9828cdd`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `65c978e`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `6ea3a78`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `a08683d`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `937bf89`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `1cc88eb`

quarkus-bot bot commented Jul 3, 2021 •

edited

Loading

Failing Jobs - Building `e7c82c7`

karesti commented Jul 6, 2021 •

edited

Loading

quarkus-bot bot commented Jul 6, 2021 •

edited

Loading

Failing Jobs - Building `6a9dec4`

quarkus-bot bot commented Jul 6, 2021 •

edited

Loading

Failing Jobs - Building `2f7352b`