IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

juliuskrah · 2022-01-11T19:09:30Z

Describe the bug

I created a quarkus project with the OpenTelemetry extension and added a custom Resource CDI Producer.

import static io.opentelemetry.semconv.resource.attributes.ResourceAttributes.SERVICE_INSTANCE_ID;

import java.util.UUID;
import javax.enterprise.context.ApplicationScoped;
import javax.enterprise.inject.Produces;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.sdk.resources.Resource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@ApplicationScoped
public class ResourceConfiguration {
    private static final Logger log = LoggerFactory.getLogger(ResourceConfiguration.class);
    
    @Produces
    @ApplicationScoped
    public Resource newRelicResource() {
        log.info("Adding custom resources {}", ResourceConfiguration.class.getName());
        return Resource.create(
            Attributes.builder().put(SERVICE_INSTANCE_ID, UUID.randomUUID().toString()).build());
    }
}

Expected behavior

The application should startup when ./mvnw clean quarkus:dev

Actual behavior

An exception is thrown

2022-01-11 16:39:21,512 DEBUG [org.hib.val.int.uti.Version] (Quarkus Main Thread) HV000001: Hibernate Validator 6.2.1.Final
2022-01-11 16:39:22,852 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile dev): java.lang.IllegalAccessError: class org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy tried to access method 'void io.opentelemetry.sdk.resources.Resource.<init>()' (org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @cd7f1ae; io.opentelemetry.sdk.resources.Resource is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @76b10754)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy.<init>(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.proxy(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:223)
        at io.quarkus.arc.impl.InstanceImpl$InstanceIterator.next(InstanceImpl.java:259)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:657)
        at io.quarkus.opentelemetry.runtime.tracing.TracerRecorder.setupResources(TracerRecorder.java:117)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy_0(Unknown Source)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy(Unknown Source)
        at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
        at io.quarkus.runtime.Application.start(Application.java:101)
        at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:104)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
        at io.quarkus.runner.GeneratedMain.main(Unknown Source)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:103)
        at java.base/java.lang.Thread.run(Thread.java:833)


2022-01-11 16:39:22,852 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile dev): java.lang.IllegalAccessError: class org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy tried to access method 'void io.opentelemetry.sdk.resources.Resource.<init>()' (org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @cd7f1ae; io.opentelemetry.sdk.resources.Resource is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @76b10754)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy.<init>(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.proxy(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:223)
        at io.quarkus.arc.impl.InstanceImpl$InstanceIterator.next(InstanceImpl.java:259)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:657)
        at io.quarkus.opentelemetry.runtime.tracing.TracerRecorder.setupResources(TracerRecorder.java:117)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy_0(Unknown Source)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy(Unknown Source)
        at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
        at io.quarkus.runtime.Application.start(Application.java:101)
        at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:104)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
        at io.quarkus.runner.GeneratedMain.main(Unknown Source)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:103)
        at java.base/java.lang.Thread.run(Thread.java:833)


2022-01-11 16:39:22,853 INFO  [io.qua.dep.dev.IsolatedDevModeMain] (main) Attempting to start live reload endpoint to recover from previous Quarkus startup failure
2022-01-11 16:39:22,853 INFO  [io.qua.dep.dev.IsolatedDevModeMain] (main) Attempting to start live reload endpoint to recover from previous Quarkus startup failure
2022-01-11 16:39:22,913 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
2022-01-11 16:39:23,002 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (main) Failed to start quarkus: java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
        at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:51)
        at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:122)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:145)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:456)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:67)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:149)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:105)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:145)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:63)
Caused by: java.lang.RuntimeException: Failed to start quarkus
        at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
        at io.quarkus.runtime.Application.start(Application.java:101)
        at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:104)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
        at io.quarkus.runner.GeneratedMain.main(Unknown Source)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:103)
        at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.IllegalAccessError: class org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy tried to access method 'void io.opentelemetry.sdk.resources.Resource.<init>()' (org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @cd7f1ae; io.opentelemetry.sdk.resources.Resource is in unnamed module of loader io.quarkus.bootstrap.classloading.QuarkusClassLoader @76b10754)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_ClientProxy.<init>(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.proxy(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at org.acme.otel.ResourceConfiguration_ProducerMethod_newRelicResource_625b8ffec6a326c4440bff06cc0a52e42734afec_Bean.get(Unknown Source)
        at io.quarkus.arc.impl.InstanceImpl.getBeanInstance(InstanceImpl.java:223)
        at io.quarkus.arc.impl.InstanceImpl$InstanceIterator.next(InstanceImpl.java:259)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.reduce(ReferencePipeline.java:657)
        at io.quarkus.opentelemetry.runtime.tracing.TracerRecorder.setupResources(TracerRecorder.java:117)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy_0(Unknown Source)
        at io.quarkus.deployment.steps.TracerProcessor$setupTracer558615094.deploy(Unknown Source)
        ... 13 more

How to Reproduce?

reproducer.zip

Output of `uname -a` or `ver`

Linux usename 5.10.60.1-microsoft-standard-WSL2

Output of `java -version`

openjdk version "17.0.1" 2021-10-19 OpenJDK Runtime Environment (build 17.0.1+12-Ubuntu-120.04) OpenJDK 64-Bit Server VM (build 17.0.1+12-Ubuntu-120.04, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.6.1.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

Apache Maven 3.8.1 (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d) Maven home: Java version: 17.0.1, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en, platform encoding: UTF-8 OS name: "linux", version: "5.10.60.1-microsoft-standard-wsl2", arch: "amd64", family: "unix"

Additional information

No response

The text was updated successfully, but these errors were encountered:

quarkus-bot · 2022-01-11T19:09:33Z

/cc @radcortez

geoand · 2022-01-12T06:22:32Z

Interesting case...

This happens because the constructor of io.opentelemetry.sdk.resources.Resource is package private which is problematic for the generated proxy. @mkouba shouldn't this be a build time error?

A workaround is to change @ApplicationScoped to @Singleton on the newRelicResource method.

juliuskrah · 2022-01-12T08:12:23Z

@geoand the workaround works. The exception is no longer thrown

mkouba · 2022-01-12T08:26:07Z

This happens because the constructor of io.opentelemetry.sdk.resources.Resource is package private which is problematic for the generated proxy. @mkouba shouldn't this be a build time error?

Yes, it's problematic because the io.opentelemetry.sdk.resources.Resource obviously comes from a different package than the ResourceConfiguration producer. I think that we should try to make the constructor protected (if quarkus.arc.transform-unproxyable-classes=true). Let me try to prepare a PR.

juliuskrah · 2022-01-12T08:41:20Z

@geoand can the custom resource be replaced with

quarkus.opentelemetry.tracer.resource-attributes=service.instance.id=${quarkus.uuid}

I don't see the traces on new relic because the service.instance.id is still not being sent in the request

geoand · 2022-01-12T09:12:54Z

That's a question for @radcortez

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

radcortez · 2022-01-12T11:18:11Z

Let me check

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

gsmet · 2022-01-25T20:14:23Z

The fix needs more work. It won't be included in 2.7.0.Final.

radcortez · 2022-02-02T12:40:29Z

I don't see the traces on new relic because the service.instance.id is still not being sent in the request

Everything looks ok to me. Are you able to check if the OTel data is correct using Jaeger for instance?

radcortez · 2022-02-02T12:41:13Z

The fix needs more work. It won't be included in 2.7.0.Final.

What is missing?

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

- use the package of the return type/field type - and use the produced type to test the app class - previously, the package of the declaring class was used - also a proxy class does not reference the bean class directly but performs a lookup via the bean identifier when instantiated - resolves quarkusio#22815

- use the package of the return type/field type - and use the produced type to test the app class - previously, the package of the declaring class was used - also a proxy class does not reference the bean class directly but performs a lookup via the bean identifier when instantiated - resolves quarkusio#22815 (cherry picked from commit c0f70cf)

juliuskrah added the kind/bug Something isn't working label Jan 11, 2022

quarkus-bot bot added the area/tracing label Jan 11, 2022

geoand added the area/arc Issue related to ARC (dependency injection) label Jan 12, 2022

mkouba added a commit to mkouba/quarkus that referenced this issue Jan 12, 2022

ArC - producers - change the client proxy class package

de67f0f

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba added a commit to mkouba/quarkus that referenced this issue Jan 12, 2022

ArC - producers - change the client proxy class package

b8c2ed9

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba mentioned this issue Jan 12, 2022

ArC - producers - change the client proxy class package #22828

Merged

mkouba added a commit to mkouba/quarkus that referenced this issue Jan 12, 2022

ArC - producers - change the client proxy class package

89eba94

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba closed this as completed in #22828 Jan 13, 2022

quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022

mkouba mentioned this issue Jan 25, 2022

Revert change client proxy class package #23185

Merged

gsmet removed this from the 2.7.0.CR1 milestone Jan 25, 2022

gsmet reopened this Jan 25, 2022

radcortez self-assigned this Jan 28, 2022

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 9, 2022

ArC - producers - change the client proxy class package

fe863f6

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 10, 2022

ArC - producers - change the client proxy class package

2a49e68

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba added a commit to mkouba/quarkus that referenced this issue Feb 11, 2022

ArC - producers - change the client proxy class package

e089471

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 13, 2022

ArC - producers - change the client proxy class package

e75b560

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 13, 2022

ArC - producers - change the client proxy class package

d585928

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 15, 2022

ArC - producers - change the client proxy class package

77c09b6

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Feb 16, 2022

ArC - producers - change the client proxy class package

10e3646

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba mentioned this issue Feb 17, 2022

ArC - producers - change the client proxy class package #23792

Merged

mkouba closed this as completed in #23792 Feb 21, 2022

quarkus-bot bot added this to the 2.8 - main milestone Feb 21, 2022

gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

juliuskrah commented Jan 11, 2022

quarkus-bot bot commented Jan 11, 2022

geoand commented Jan 12, 2022

juliuskrah commented Jan 12, 2022 •

edited

Loading

mkouba commented Jan 12, 2022

juliuskrah commented Jan 12, 2022

geoand commented Jan 12, 2022

radcortez commented Jan 12, 2022

gsmet commented Jan 25, 2022

radcortez commented Feb 2, 2022

radcortez commented Feb 2, 2022

IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

Comments

juliuskrah commented Jan 11, 2022

Describe the bug

Expected behavior

Actual behavior

How to Reproduce?

Output of uname -a or ver

Output of java -version

GraalVM version (if different from Java)

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

Additional information

quarkus-bot bot commented Jan 11, 2022

geoand commented Jan 12, 2022

juliuskrah commented Jan 12, 2022 • edited Loading

mkouba commented Jan 12, 2022

juliuskrah commented Jan 12, 2022

geoand commented Jan 12, 2022

radcortez commented Jan 12, 2022

gsmet commented Jan 25, 2022

radcortez commented Feb 2, 2022

radcortez commented Feb 2, 2022

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

juliuskrah commented Jan 12, 2022 •

edited

Loading