ArC - producers - change the client proxy class package #22828

mkouba · 2022-01-12T10:13:52Z

use the package of the return type/field type
previously, the package of the declaring class was used
resolves IllegalAccessError when using OpenTelemetry extension with custom Resource #22815

manovotn

What's the point of havingProducerReturnTypePackagePrivateNoArgsConstructorTest twice (once in arc and once under extensions)? They seem identical. Did you mean to change the constructor of Resource in one of them?

manovotn · 2022-01-12T10:48:10Z

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanInfo.java

+            DotName typeName = target.kind() == Kind.FIELD ? target.asField().type().name()
+                    : target.asMethod().returnType().name();
+            String packageName = DotNames.packageName(typeName);
+            if (packageName.startsWith("java.")) {


I recall in Weld we were replacing a regex of java.* meaning we'd replace even javax.something etc. And latest version also does that for jakarta package but TBF I don't remember why we chose/needed to do that...

TBF I don't remember why we chose/needed to do that...

Exactly. That's the reason why we only keep java. for now ;-).

Ladicek

LGTM, though I also don't understand why the test is needed twice. Probably just to be sure?

mkouba · 2022-01-12T12:44:21Z

What's the point of havingProducerReturnTypePackagePrivateNoArgsConstructorTest twice (once in arc and once under extensions)? They seem identical. Did you mean to change the constructor of Resource in one of them?

LGTM, though I also don't understand why the test is needed twice. Probably just to be sure?

Well, one of the tests is most likely redundant. The original idea was to have a test for ArC standalone and one for Quarkus (because of the bytecode transformation and the test classloaders fun).

manovotn · 2022-01-12T14:25:19Z

Well, one of the tests is most likely redundant. The original idea was to have a test for ArC standalone and one for Quarkus (because of the bytecode transformation and the test classloaders fun).

I see. In that case it might be worth adding a comment linking them together and mentioning the reason they are duplicated :-)

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba · 2022-01-12T16:12:14Z

Well, one of the tests is most likely redundant. The original idea was to have a test for ArC standalone and one for Quarkus (because of the bytecode transformation and the test classloaders fun).

I see. In that case it might be worth adding a comment linking them together and mentioning the reason they are duplicated :-)

Done ;-)

quarkus-bot · 2022-01-12T20:29:05Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `89eba94`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.BeanInTestSourcesTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.gradle.KotlinGRPCProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiModuleKotlinProjectBuildTest.testBasicMultiModuleBuild line 15 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

✖ io.quarkus.gradle.MultiSourceProjectTest.shouldRunTest line 16 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: "SUCCESS"

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-hibernate

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 60 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with com.example.grpc.hibernate.BlockingRawTest was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

quarkus-bot · 2022-01-13T11:28:38Z

Failing Jobs - Building `89eba94`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.JandexMultiModuleProjectDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

- and use the produced type to test the app class - follows up on quarkusio#22828

mkouba requested review from Ladicek and manovotn January 12, 2022 10:14

quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jan 12, 2022

manovotn reviewed Jan 12, 2022

View reviewed changes

Ladicek approved these changes Jan 12, 2022

View reviewed changes

ArC - producers - change the client proxy class package

89eba94

- use the package of the return type/field type - previously, the package of the declaring class was used - resolves quarkusio#22815

mkouba force-pushed the issue-22815 branch from b8c2ed9 to 89eba94 Compare January 12, 2022 16:12

mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 12, 2022

manovotn approved these changes Jan 12, 2022

View reviewed changes

mkouba merged commit f3fe07e into quarkusio:main Jan 13, 2022

quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 13, 2022

mkouba added a commit to mkouba/quarkus that referenced this pull request Jan 14, 2022

ClientProxyGenerator - fix app class test for producers

f94384d

- and use the produced type to test the app class - follows up on quarkusio#22828

mkouba added a commit to mkouba/quarkus that referenced this pull request Jan 14, 2022

ClientProxyGenerator - fix app class test for producers

54b74c5

- and use the produced type to test the app class - follows up on quarkusio#22828

mkouba mentioned this pull request Jan 14, 2022

ClientProxyGenerator - fix app class test for producers #22893

Merged

aloubyansky mentioned this pull request Jan 25, 2022

LinkageError when hot reloading project using classes in external dependencies #23167

Closed

mkouba mentioned this pull request Feb 8, 2022

Revert change client proxy class package #23185

Merged

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Feb 9, 2022

ClientProxyGenerator - fix app class test for producers

1e4f870

- and use the produced type to test the app class - follows up on quarkusio#22828

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Feb 10, 2022

ClientProxyGenerator - fix app class test for producers

114ba74

- and use the produced type to test the app class - follows up on quarkusio#22828

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Feb 13, 2022

ClientProxyGenerator - fix app class test for producers

3dd8be1

- and use the produced type to test the app class - follows up on quarkusio#22828

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Feb 13, 2022

ClientProxyGenerator - fix app class test for producers

7a11fcb

- and use the produced type to test the app class - follows up on quarkusio#22828

aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Feb 16, 2022

ClientProxyGenerator - fix app class test for producers

8f2e343

- and use the produced type to test the app class - follows up on quarkusio#22828

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ArC - producers - change the client proxy class package #22828

ArC - producers - change the client proxy class package #22828

mkouba commented Jan 12, 2022

manovotn left a comment

manovotn Jan 12, 2022

mkouba Jan 12, 2022

Ladicek left a comment

mkouba commented Jan 12, 2022

manovotn commented Jan 12, 2022

mkouba commented Jan 12, 2022

quarkus-bot bot commented Jan 12, 2022 •

edited

Loading

Failing Jobs - Building `89eba94`

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/grpc-hibernate

quarkus-bot bot commented Jan 13, 2022

ArC - producers - change the client proxy class package #22828

ArC - producers - change the client proxy class package #22828

Conversation

mkouba commented Jan 12, 2022

manovotn left a comment

Choose a reason for hiding this comment

manovotn Jan 12, 2022

Choose a reason for hiding this comment

mkouba Jan 12, 2022

Choose a reason for hiding this comment

Ladicek left a comment

Choose a reason for hiding this comment

mkouba commented Jan 12, 2022

manovotn commented Jan 12, 2022

mkouba commented Jan 12, 2022

quarkus-bot bot commented Jan 12, 2022 • edited Loading

Failing Jobs - Building 89eba94

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/grpc-hibernate

quarkus-bot bot commented Jan 13, 2022

Failing Jobs - Building 89eba94

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

quarkus-bot bot commented Jan 12, 2022 •

edited

Loading

Failing Jobs - Building `89eba94`

Failing Jobs - Building `89eba94`