Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE when using io.quarkus.cli.commands.CreateProject.doCreateProject() on native image #3331

Closed
ia3andy opened this issue Jul 25, 2019 · 4 comments · Fixed by #3480
Closed

NPE when using io.quarkus.cli.commands.CreateProject.doCreateProject() on native image #3331

ia3andy opened this issue Jul 25, 2019 · 4 comments · Fixed by #3480
Labels
kind/bug Something isn't working
Milestone
0.21.0

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Jul 25, 2019

Describe the bug
Having NPE when using when using io.quarkus.cli.commands.CreateProject.doCreateProject() on native image. I suppose the template are not automatically included

2019-07-25 11:42:30,588 ERROR [io.und.req.io] (executor-thread-1) Exception handling request de13b80e-5c67-479a-bd61-b2c9b73ba68d-1 to /api/quarkus/download: org.jboss.resteasy.spi.UnhandledException: java.lang.NullPointerException
--
  | at org.jboss.resteasy.core.ExceptionHandler.handleApplicationException(ExceptionHandler.java:106)
  | at org.jboss.resteasy.core.ExceptionHandler.handleException(ExceptionHandler.java:372)
  | at org.jboss.resteasy.core.SynchronousDispatcher.writeException(SynchronousDispatcher.java:209)
  | at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:496)
  | at org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:252)
  | at org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:153)
  | at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:363)
  | at org.jboss.resteasy.core.SynchronousDispatcher.preprocess(SynchronousDispatcher.java:156)
  | at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:238)
  | at org.jboss.resteasy.plugins.server.servlet.ServletContainerDispatcher.service(ServletContainerDispatcher.java:249)
  | at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:60)
  | at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:55)
  | at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
  | at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
  | at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
  | at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
  | at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
  | at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:132)
  | at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
  | at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
  | at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
  | at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
  | at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
  | at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
  | at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
  | at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
  | at io.quarkus.undertow.runtime.RewriteCorrectingHandlerWrappers$PostWrapper$1.handleRequest(RewriteCorrectingHandlerWrappers.java:51)
  | at io.undertow.predicate.PredicatesHandler.handleRequest(PredicatesHandler.java:110)
  | at io.undertow.server.handlers.RequestDumpingHandler.handleRequest(RequestDumpingHandler.java:162)
  | at io.undertow.predicate.PredicatesHandler.handleRequest(PredicatesHandler.java:93)
  | at io.undertow.server.handlers.SetHeaderHandler.handleRequest(SetHeaderHandler.java:90)
  | at io.undertow.predicate.PredicatesHandler.handleRequest(PredicatesHandler.java:93)
  | at io.quarkus.undertow.runtime.RewriteCorrectingHandlerWrappers$PreWrapper$1.handleRequest(RewriteCorrectingHandlerWrappers.java:31)
  | at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
  | at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
  | at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
  | at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
  | at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
  | at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
  | at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
  | at io.quarkus.undertow.runtime.UndertowDeploymentRecorder$8$1$1.call(UndertowDeploymentRecorder.java:483)
  | at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
  | at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
  | at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
  | at io.undertow.server.Connectors.executeRootHandler(Connectors.java:364)
  | at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
  | at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
  | at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:2011)
  | at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1538)
  | at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1429)
  | at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
  | at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:32)
  | at java.lang.Thread.run(Thread.java:748)
  | at org.jboss.threads.JBossThread.run(JBossThread.java:479)
  | at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:473)
  | at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:193)
  | Caused by: java.lang.NullPointerException
  | at java.io.Reader.<init>(Reader.java:78)
  | at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
  | at io.quarkus.templates.rest.BasicRest.generate(BasicRest.java:119)
  | at io.quarkus.templates.rest.BasicRest.initProject(BasicRest.java:98)
  | at io.quarkus.templates.rest.BasicRest.generate(BasicRest.java:47)
  | at io.quarkus.cli.commands.CreateProject.doCreateProject(CreateProject.java:127)
  | at io.launcher.quarkus.LauncherQuarkus.download(LauncherQuarkus.kt:52)
  | at io.launcher.quarkus.LauncherQuarkus_Subclass.download$$superaccessor1(LauncherQuarkus_Subclass.zig:120)
  | at io.launcher.quarkus.LauncherQuarkus_Subclass$$function$$1.apply(LauncherQuarkus_Subclass$$function$$1.zig:51)
  | at io.quarkus.arc.InvocationContextImpl.interceptorChainCompleted(InvocationContextImpl.java:141)
  | at io.quarkus.arc.InvocationContextImpl.proceed(InvocationContextImpl.java:161)
  | at io.quarkus.hibernate.validator.runtime.interceptor.AbstractMethodValidationInterceptor.validateMethodInvocation(AbstractMethodValidationInterceptor.java:67)
  | at io.quarkus.hibernate.validator.runtime.jaxrs.JaxrsEndPointValidationInterceptor.validateMethodInvocation(JaxrsEndPointValidationInterceptor.java:29)
  | at io.quarkus.hibernate.validator.runtime.jaxrs.JaxrsEndPointValidationInterceptor_Bean.intercept(JaxrsEndPointValidationInterceptor_Bean.zig:106)
  | at io.quarkus.arc.InvocationContextImpl$InterceptorInvocation.invoke(InvocationContextImpl.java:254)
  | at io.quarkus.arc.InvocationContextImpl.invokeNext(InvocationContextImpl.java:133)
  | at io.quarkus.arc.InvocationContextImpl.proceed(InvocationContextImpl.java:157)
  | at io.launcher.quarkus.LauncherQuarkus_Subclass.download(LauncherQuarkus_Subclass.zig:204)
  | at java.lang.reflect.Method.invoke(Method.java:498)
  | at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:151)
  | at org.jboss.resteasy.core.MethodInjectorImpl.lambda$invoke$3(MethodInjectorImpl.java:122)
  | at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
  | at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:614)
  | at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1983)
  | at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:110)
  | at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:122)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:580)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:454)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$2(ResourceMethodInvoker.java:408)
  | at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:363)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:410)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:379)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invoke$1(ResourceMethodInvoker.java:353)
  | at java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:981)
  | at java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2124)
  | at java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:110)
  | at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:353)
  | at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:477)
  | ... 52 more

Expected behavior
(Describe the expected behavior clearly and concisely.)

Actual behavior
(Describe the actual behavior clearly and concisely.)

To Reproduce
Steps to reproduce the behavior:

  1. Use doCreateProject with a valid CreateProject in a quarkus project and bind it to a rest endpoint
  2. Create a native image
  3. Call

example: https://github.com/fabric8-launcher/launcher-quarkus/blob/master/src/main/kotlin/io/launcher/quarkus/LauncherQuarkus.kt#L52

Workaround

<plugin>
                <groupId>io.quarkus</groupId>
                <artifactId>quarkus-maven-plugin</artifactId>
                <version>${version.quarkus}</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>build</goal>
                        </goals>
                        <configuration>
                            <additionalBuildArgs>-H:IncludeResources=templates/.*</additionalBuildArgs>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
@ia3andy ia3andy added the kind/bug Something isn't working label Jul 25, 2019
@geoand
Copy link
Contributor

geoand commented Aug 10, 2019

@ia3andy is this still an issue?

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 12, 2019

@geoand yes, I'll provide a PR ;-)

@geoand
Copy link
Contributor

geoand commented Aug 12, 2019

OK, thanks :)

ia3andy added a commit to ia3andy/quarkus that referenced this issue Aug 12, 2019
@ia3andy
Fix NPE in BasicRestProjectGenerator when a resource is missing
508de04 
Throw a dedicated IOException instead.
Closes quarkusio#3331
@ia3andy ia3andy mentioned this issue Aug 12, 2019
Merged
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 12, 2019

@geoand PR submitted ;-)

ia3andy added a commit to ia3andy/quarkus that referenced this issue Aug 12, 2019
@ia3andy
Fix NPE in BasicRestProjectGenerator when a resource is missing
71e62c9 
Throw a dedicated IOException instead.
Closes quarkusio#3331
ia3andy added a commit to ia3andy/quarkus that referenced this issue Aug 12, 2019
@ia3andy
Fix NPE in BasicRestProjectGenerator when a resource is missing
826ffdb 
Throw a dedicated IOException instead.
Closes quarkusio#3331
@gsmet gsmet added this to the 0.21.0 milestone Aug 13, 2019
Dufgui pushed a commit to Dufgui/quarkus that referenced this issue Aug 26, 2019
@ia3andy @Dufgui
Fix NPE in BasicRestProjectGenerator when a resource is missing
ab7f053 
Throw a dedicated IOException instead.
Closes quarkusio#3331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

Fix NPE in BasicRestProjectGenerator when a resource is missing ia3andy/quarkus
3 participants
@gsmet @ia3andy @geoand