Fix NPE in BasicRestProjectGenerator when a resource is missing #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Aug 12, 2019
| import java.io.ByteArrayInputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStreamReader; | ||
| import java.io.*; |
There was a problem hiding this comment.
We don't do star imports, could you change that?
gsmet
reviewed
Aug 12, 2019
| @@ -111,8 +108,12 @@ private void generate(final String templateName, final Map<String, Object> conte | |||
| throws IOException { | |||
| if (!writer.exists(outputFilePath)) { | |||
| String path = templateName.startsWith("/") ? templateName : "/" + templateName; | |||
| InputStream resourceStream = getClass().getResourceAsStream(path); | |||
There was a problem hiding this comment.
Wondering if we should have a try with resources here and properly close the stream?
|
@gsmet how does that sound now? |
gsmet
added
the
triage/waiting-for-ci
Throw a dedicated IOException instead. Closes quarkusio#3331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a dedicated IOException instead.
Closes #3331