Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a RESTEasy Multipart extension #880

Closed
gastaldi opened this issue Feb 13, 2019 · 9 comments · Fixed by #11893
Closed

Introduce a RESTEasy Multipart extension #880

gastaldi opened this issue Feb 13, 2019 · 9 comments · Fixed by #11893

Comments

@gastaldi
Copy link
Contributor

RESTEasy has rich support for the multipart/* and multipart/form-data mime types. The multipart mime format is used to pass lists of content bodies. Multiple content bodies are embedded in one message. multipart/form-data is often found in web application HTML Form documents and is generally used to upload files. The form-data format is the same as other multipart formats, except that each inlined piece of content has a name associated with it.

It should be supported in Protean too.

@stuartwdouglas
Copy link
Member

This should just be added into the bom

@gastaldi
Copy link
Contributor Author

Just so I get this right: the resteasy.version and the dependency below should be added to the bom?

         <dependency>
            <groupId>org.jboss.resteasy</groupId>
            <artifactId>resteasy-multipart-provider</artifactId>
            <version>${resteasy.version}</version>
            <exclusions>
               <exclusion>
                  <groupId>org.jboss.spec.javax.annotation</groupId>
                  <artifactId>jboss-annotations-api_1.3_spec</artifactId>
               </exclusion>
               <exclusion>
                  <groupId>javax.activation</groupId>
                  <artifactId>activation</artifactId>
               </exclusion>
            </exclusions>
         </dependency>

@stuartwdouglas
Copy link
Member

We probably want to consume the Resteasy bom, and then have our build parent import the bom as well. I am looking into it.

@Sanne Sanne closed this as completed in 956ac1a Feb 14, 2019
Sanne added a commit that referenced this issue Feb 14, 2019
Fixes #880, add Resteasy to the bom so the version aligns
@gsmet gsmet reopened this Feb 14, 2019
cescoffier added a commit that referenced this issue Feb 14, 2019
Revert "Fixes #880, add Resteasy to the bom so the version aligns"
@gastaldi
Copy link
Contributor Author

Can someone reopen this issue?

@Sanne Sanne reopened this Feb 14, 2019
@gsmet
Copy link
Member

gsmet commented Mar 2, 2019

@gastaldi I think I fixed the issue with the new BOM. You should be able to simply add the dependency with no versions. Can you check and close if OK? Thanks!

@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 3, 2019

I can confirm that the new BOM contains the necessary RESTEasy artifacts. Here is what I added to make this work:

    <dependency>
      <groupId>org.jboss.resteasy</groupId>
      <artifactId>resteasy-multipart-provider</artifactId>
      <exclusions>
        <exclusion>
          <groupId>org.jboss.spec.javax.annotation</groupId>
          <artifactId>jboss-annotations-api_1.3_spec</artifactId>
        </exclusion>
        <exclusion>
          <groupId>javax.activation</groupId>
          <artifactId>activation</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

@gastaldi gastaldi closed this as completed Mar 3, 2019
@gsmet gsmet reopened this Mar 3, 2019
@gsmet
Copy link
Member

gsmet commented Mar 3, 2019

@gastaldi reopening as if we should include that configuration in the BOM. Will do.

@gsmet gsmet self-assigned this Mar 3, 2019
@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 4, 2019

@gsmet just tested and when removing the exclusions I haven't noticed any errors

@gastaldi
Copy link
Contributor Author

gastaldi commented Apr 5, 2019

I can confirm that adding the following dependency is enough. Tested in 0.12.0:

    <dependency>
      <groupId>org.jboss.resteasy</groupId>
      <artifactId>resteasy-multipart-provider</artifactId>
    </dependency>

Example: https://github.com/fabric8-launcher/launcher-backend/blob/02910f3aa9606507302ccba544d529ea6d9acac3/web/pom.xml#L85-L88

@gsmet gsmet closed this as completed Nov 5, 2019
@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 5, 2019
@gastaldi gastaldi changed the title Support JAX-RS Multipart Introduce a RESTEasy Multipart extension Sep 11, 2020
@gastaldi gastaldi reopened this Sep 11, 2020
@gastaldi gastaldi linked a pull request Sep 11, 2020 that will close this issue
@gastaldi gastaldi added kind/new-feature release/noteworthy-feature and removed triage/out-of-date This issue/PR is no longer valid or relevant labels Sep 11, 2020
@gastaldi gastaldi added this to the 1.9.0 - master milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants