Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #880: Integrate JAXRS-Multipart extension #879

Closed
wants to merge 1 commit into from
Closed

Fixes #880: Integrate JAXRS-Multipart extension #879

wants to merge 1 commit into from

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Feb 13, 2019

Fixes #880

@gastaldi gastaldi changed the title Integrate JAXRS-Multipart extension Fixes #880: Integrate JAXRS-Multipart extension Feb 13, 2019
Fixes #880

Signed-off-by: George Gastaldi <[email protected]>
@gsmet
Copy link
Member

gsmet commented Feb 13, 2019

Hmm, is there any value in this extension? I mean just adding the dependency would be sufficient, wouldn't it?

Wondering if multipart is sufficiently important that we need to expose it as an extension. I don't think we want to create an extension for each JAX-RS provider.

@gastaldi
Copy link
Contributor Author

gastaldi commented Feb 13, 2019

@gsmet I copied from the jaxrs-json extension, which falls in the same category.

Otherwise you'd need to add the dependency to resteasy-multipart-provider with the same supported RESTEasy version (and with the proper exclusions), which I am not sure is available when building the project.

@gsmet
Copy link
Member

gsmet commented Feb 13, 2019

Yes, we did that for JSON because it was the most common use case. Not sure it's worth doing the same for multipart.

We could add it to the bom to mandate the right version.

@gastaldi
Copy link
Contributor Author

I'm fine with whatever strategy you guys choose 😄 I just want to make my app work 😉

@gastaldi
Copy link
Contributor Author

@gsmet WDYT about merging this PR and revisiting the strategy for using different providers in a separate PR?

@stuartwdouglas
Copy link
Member

This really should just be an entry in the bom

@gastaldi gastaldi deleted the jaxrs_multipart branch February 13, 2019 23:18
@cescoffier cescoffier added the triage/wontfix This will not be worked on label Feb 14, 2019
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants