Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure import.sql charset #9542

Closed
danowrw opened this issue May 22, 2020 · 3 comments
Closed

Add option to configure import.sql charset #9542

danowrw opened this issue May 22, 2020 · 3 comments
Labels
area/hibernate-orm Hibernate ORM good first issue Good for newcomers kind/enhancement New feature or request triage/invalid This doesn't seem right

Comments

@danowrw
Copy link

danowrw commented May 22, 2020

Description
For now quarkus uses system default charset for import.sql. This causes errors depending on which system it is run.

Implementation ideas
Please add an option to configure hibernate.hbm2ddl.charset_name from quarkus properties.
@danowrw danowrw added the kind/enhancement New feature or request label May 22, 2020
@jaikiran jaikiran added the area/hibernate-orm Hibernate ORM label May 23, 2020
@gsmet gsmet added the good first issue Good for newcomers label May 25, 2020
geoand added a commit to geoand/quarkus that referenced this issue May 25, 2020
@geoand
Add DDL charset support for import.sql file
ee21ece 
Fixes: quarkusio#9542
This was referenced May 25, 2020
Merged
Closed
@geoand
Copy link
Contributor

geoand commented May 25, 2020 •
edited by gsmet
Loading

@danowrw you can set hibernate.hbm2ddl.charset_name by setting quarkus.hibernate.database.charset

geoand added a commit that referenced this issue May 26, 2020
@geoand
Merge pull request #9570 from geoand/#9542
eafe54b 
Support Charset in Quarkus Config - Use it in Hibernate
@xstefank
Copy link
Member

@geoand so this can be closed I believe?

@geoand
Copy link
Contributor

geoand commented Jul 27, 2020

Yes, that is correct

@geoand geoand closed this as completed Jul 27, 2020
@geoand geoand added the triage/invalid This doesn't seem right label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM good first issue Good for newcomers kind/enhancement New feature or request triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jaikiran @gsmet @geoand @xstefank @danowrw