-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Charset in Quarkus Config - Use it in Hibernate #9570
Conversation
...ate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments. But my main issue is that it's already implemented.
core/runtime/src/main/java/io/quarkus/runtime/configuration/CharsetConverter.java
Outdated
Show resolved
Hide resolved
...ate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfig.java
Outdated
Show resolved
Hide resolved
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java
Outdated
Show resolved
Hide resolved
@gsmet given that indeed it's already implement (:facepalm:), should I just change the PR to add the converter and set UTF-8 as the default? |
+1 to just default to UTF-8. But also, should we just enforce it rather than expose the configuration property? We're still trying hard to expose esclusively what can't be avoided. If there's a real need for people to choose a charsets which is different than UTF-8, maybe we should have a "Quarkus global resource handlng" property which applies consistently to all resources handled by Quarkus? I mean: across all extensions rather than having an Hibernate specific property. |
For now the PR was updated to just add the converter for |
Good idea about the global UTF-8 handling. But sounds like something for a follow up PR? |
@Sanne we already decided to expose it as it was exposed since the very beginning (and I only exposed those that were in your list). |
...ate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfig.java
Outdated
Show resolved
Hide resolved
...ate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfig.java
Show resolved
Hide resolved
e958eba
to
a975545
Compare
f594dd6
to
7e8875a
Compare
Relates to: #9542
Also set the default charset for Hibernate to
UTF-8