Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Charset in Quarkus Config - Use it in Hibernate #9570

Merged
merged 2 commits into from
May 26, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 25, 2020

Relates to: #9542

Also set the default charset for Hibernate to UTF-8

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. But my main issue is that it's already implemented.

@geoand
Copy link
Contributor Author

geoand commented May 25, 2020

@gsmet given that indeed it's already implement (:facepalm:), should I just change the PR to add the converter and set UTF-8 as the default?

@Sanne
Copy link
Member

Sanne commented May 25, 2020

+1 to just default to UTF-8.

But also, should we just enforce it rather than expose the configuration property? We're still trying hard to expose esclusively what can't be avoided.

If there's a real need for people to choose a charsets which is different than UTF-8, maybe we should have a "Quarkus global resource handlng" property which applies consistently to all resources handled by Quarkus? I mean: across all extensions rather than having an Hibernate specific property.

@geoand
Copy link
Contributor Author

geoand commented May 25, 2020

For now the PR was updated to just add the converter for Charset and set the default value for Hibernate to UTF-8

@geoand
Copy link
Contributor Author

geoand commented May 25, 2020

Good idea about the global UTF-8 handling. But sounds like something for a follow up PR?

@geoand geoand changed the title Add DDL charset support for import.sql file Support Charset in Quarkus Config - Use it in Hibernate May 25, 2020
@geoand geoand requested a review from gsmet May 25, 2020 13:17
@gsmet
Copy link
Member

gsmet commented May 25, 2020

@Sanne we already decided to expose it as it was exposed since the very beginning (and I only exposed those that were in your list).

@geoand geoand force-pushed the #9542 branch 2 times, most recently from e958eba to a975545 Compare May 25, 2020 13:25
@geoand geoand requested a review from gsmet May 25, 2020 13:33
@geoand geoand force-pushed the #9542 branch 3 times, most recently from f594dd6 to 7e8875a Compare May 26, 2020 08:42
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 26, 2020
@gsmet gsmet added this to the 1.6.0 milestone May 26, 2020
@geoand geoand merged commit eafe54b into quarkusio:master May 26, 2020
@geoand geoand deleted the #9542 branch May 26, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants