Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev mode: fixed discovery of local dependencies inherited from parents #10556

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Dev mode: fixed discovery of local dependencies inherited from parents #10556

merged 2 commits into from
Jul 10, 2020

Conversation

aloubyansky
Copy link
Member

Fixes #10484

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jul 8, 2020
@aloubyansky aloubyansky mentioned this pull request Jul 8, 2020
Closed
@famod
Copy link
Member

famod commented Jul 8, 2020

What about dep.getRawModel().getDependencies() here?https://github.com/aloubyansky/quarkus/blob/10484/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java#L916

@geoand
Copy link
Contributor

geoand commented Jul 8, 2020

Please rebase this onto master to up a CI fix

@aloubyansky
Copy link
Member Author

What about dep.getRawModel().getDependencies() here?https://github.com/aloubyansky/quarkus/blob/10484/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java#L916

I re-implemented it and added a test for a project that includes an extension.

@stuartwdouglas
Copy link
Member

@aloubyansky needs a rebase

@aloubyansky aloubyansky merged commit 160bdf3 into quarkusio:master Jul 10, 2020
@famod
Copy link
Member

famod commented Jul 10, 2020

Would be great if this could be backported.

@aloubyansky
Copy link
Member Author

It's not a regression though. I'll let @gsmet decide.

@geoand
Copy link
Contributor

geoand commented Jul 10, 2020

It might be a little to risky to include in 1.6?

@famod
Copy link
Member

famod commented Jul 10, 2020

Well, not entirely sure whether this is really comparable but #10576 is marked for backporting (potentially).

But I won't die if it is not backported. 😉

@aloubyansky
Copy link
Member Author

Don't @famod we count on you

@gsmet gsmet added this to the 1.7.0 - master milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Devmode, Maven: Broken classpath when a local module depends via its parent on another local module
5 participants
@aloubyansky @famod @geoand @stuartwdouglas @gsmet