Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Maven start and stop the Docker images and other CI adjustments #11679

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Let Maven start and stop the Docker images and other CI adjustments #11679

merged 4 commits into from
Aug 28, 2020
+41 −110

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 27, 2020

No description provided.

@boring-cyborg boring-cyborg bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Aug 27, 2020
@gsmet
Copy link
Member Author

gsmet commented Aug 27, 2020

@machi1990 I just stumbled upon the fact that the Redis integration tests do not have a docker profile allowing to start Redis from Maven. Any chance you could take care of that?

@machi1990
Copy link
Member

@machi1990 I just stumbled upon the fact that the Redis integration tests do not have a docker profile allowing to start Redis from Maven. Any chance you could take care of that?

Sure. Okay, do you want me to push a commit in this branch or on a separate PR?

@gsmet
Copy link
Member Author

gsmet commented Aug 27, 2020

Keep it on your side for now. I want this PR to run fully :). But you can push to it tomorrow, I'm on PTO.

Don't forget the docker prune script. There are a few examples in existing modules.

@gsmet
Copy link
Member Author

gsmet commented Aug 27, 2020

A good example: https://github.com/quarkusio/quarkus/blob/master/integration-tests/jpa-postgresql/pom.xml#L206

@machi1990
Copy link
Member

Keep it on your side for now. I want this PR to run fully :). But you can push to it tomorrow, I'm on PTO.

Don't forget the docker prune script. There are a few examples in existing modules.

Sure, I had all the resources I needed :-)

PR opened here #11686

@gsmet gsmet changed the title [Do not merge] Experiment with letting Maven start and stop the Docker images Experiment with letting Maven start and stop the Docker images Aug 27, 2020
@gsmet gsmet changed the title Experiment with letting Maven start and stop the Docker images Let Maven start and stop the Docker images and other CI adjustments Aug 27, 2020
@gsmet gsmet added area/infra internal and infrastructure related issues priority/urgent labels Aug 27, 2020
@geoand geoand mentioned this pull request Aug 27, 2020
Merged
@jaikiran jaikiran mentioned this pull request Aug 28, 2020
Merged
@geoand geoand merged commit 224fb5f into quarkusio:master Aug 28, 2020
@geoand geoand added this to the 1.8.0 - master milestone Aug 28, 2020
@gsmet gsmet mentioned this pull request Aug 28, 2020
Closed
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.2.Final Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/infra internal and infrastructure related issues area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure priority/urgent
Projects
None yet
Milestone
1.7.2.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @machi1990 @geoand