Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MutinyTest#testSSE for now as it's unstable on CI #11693

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Disable MutinyTest#testSSE for now as it's unstable on CI #11693

merged 1 commit into from
Aug 28, 2020

Conversation

jaikiran
Copy link
Member

Requesting approval to merge this one. Our other CI experiment PRs keep running into this one and we haven't been able to run those jobs to completion. This commit has been tested in @gsmet's #11679 PR (which is currently open), so I don't think we have to wait for the whole 2-3 hours to merge this PR.

/cc @stuartwdouglas @geoand

@jaikiran jaikiran merged commit a2494f6 into quarkusio:master Aug 28, 2020
@jaikiran jaikiran added this to the 1.8.0 - master milestone Aug 28, 2020
@jaikiran
Copy link
Member Author

Thank you @geoand

@geoand
Copy link
Contributor

geoand commented Aug 28, 2020

Thank you!

@jaikiran jaikiran deleted the mutiny-sse-disable branch August 28, 2020 06:08
@cescoffier
Copy link
Member

cescoffier commented Aug 28, 2020

This test became unstable without any reason. Neither mutiny or resteasy mutiny have changed recently.
I don't believe there is another SSE test (in native) at the moment.

As I said on Zulip, we should have stopped and go back in time to understand.

@jaikiran
Copy link
Member Author

Hello @cescoffier, I think at this point the CI has reached a completely unreliable state. So trying to make sense of some these failures is turning out to be almost impossible. It's very likely that this issue in this test is due to other factors and I think we should enable this back once the CI reaches some state of reliability (hopefully soon). There are some open PRs which are solely trying to resolve these CI issues. So once those reach some conclusive stage, I think we should just re-enable this test.

@jaikiran
Copy link
Member Author

@cescoffier, things have now stabilized to a major extent in master branch. I will open a PR to revert this disabled test back to its previous state, either tonight or early tomorrow (just want to give a few hours for the CI to settle down and pending PRs to be processed before we start looking into this again).

@jaikiran
Copy link
Member Author

I've now opened #11727 to revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants