Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GraalVM 20.3.1 #14455

Closed
wants to merge 1 commit into from
Closed

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 20, 2021

Want to upgrade to 20.3.1 first as we will probably backport it to 1.11.

Creating as draft for now to see how it goes in my fork.

Want to upgrade to 20.3.1 first as we will probably backport it to 1.11.
@ghost ghost added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/tika labels Jan 20, 2021
@gsmet
Copy link
Member Author

gsmet commented Jan 20, 2021

/cc @zakkak FYI

@zakkak
Copy link
Contributor

zakkak commented Jan 20, 2021

Hi @gsmet I have prepared a similar branch (https://github.com/zakkak/quarkus/tree/graal-20.3.1-update)

In which in addition to what you reverted, I also revert 9e0a94e and af31023.

Note: I would prefer the changes that revert commits to be explicit reverts (see https://github.com/zakkak/quarkus/commits/graal-20.3.1-update) since that makes it easier to track and understand the changes in the future.

@gsmet
Copy link
Member Author

gsmet commented Jan 20, 2021

I don't mind if you prefer your branch but you need to put the commits the other way around: first the upgrade, then revert the unnecessary things we added for 20.3.0.

I can close this one if we go with your PR.

@zakkak
Copy link
Contributor

zakkak commented Jan 20, 2021

OK let me do the change and open another draft PR then.

@gsmet gsmet closed this Jan 20, 2021
@ghost ghost added the triage/invalid This doesn't seem right label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/tika triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants