Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to GraalVM 20.3.1 #14457

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Upgrade to GraalVM 20.3.1 #14457

merged 7 commits into from
Jan 21, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jan 20, 2021 •
edited
Loading

Replaces #14455

Copying @gsmet's original PR body:

Want to upgrade to 20.3.1 first as we will probably backport it to 1.11.

Creating as draft for now to see how it goes in my fork.

Reverts changes made to work around issues introduced by 20.3.0 that are no longer present in 20.3.1 (see #13644).
More specifically it reverts:

@ghost ghost added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/tika labels Jan 20, 2021
gsmet
gsmet requested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small gripe.

@zakkak zakkak self-assigned this Jan 20, 2021
@zakkak
Copy link
Contributor Author

zakkak commented Jan 21, 2021 •
edited
Loading

CI looks good (except for "MicroProfile TCKs Tests" which timed out and AFAIU is irrelevant to the GraalVM update) : https://github.com/zakkak/quarkus/actions/runs/499615927

@gsmet gsmet marked this pull request as ready for review January 21, 2021 11:03
@gsmet
Copy link
Member

gsmet commented Jan 21, 2021

Let's promote it then!

@gsmet gsmet merged commit 27b8bc7 into quarkusio:master Jan 21, 2021
@ghost ghost added this to the 1.12 - master milestone Jan 21, 2021
@gsmet
Copy link
Member

gsmet commented Jan 21, 2021

Merged! Nice work @zakkak .

I think we can work on moving master to 21.0 now, will you do it?

@gsmet gsmet modified the milestones: 1.12 - master, 1.11.1.Final Jan 21, 2021
@zakkak zakkak deleted the graal-20.3.1-update branch January 21, 2021 21:34
@zakkak
Copy link
Contributor Author

zakkak commented Jan 21, 2021

Merged! Nice work @zakkak .

Thanks

I think we can work on moving master to 21.0 now, will you do it?

Sure :)

@zakkak zakkak mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

@zakkak zakkak

Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/tika release/noteworthy-feature
Projects
None yet
Milestone
1.11.1.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@zakkak @gsmet