Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GraalVM 20.3.1 #14457

Merged
merged 7 commits into from
Jan 21, 2021
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<maven-plugin-annotations.version>3.6.0</maven-plugin-annotations.version>
<plexus-component-annotations.version>2.1.0</plexus-component-annotations.version>
<!-- What we actually depend on for the annotations, as latest Graal is not available in Maven fast enough: -->
<graal-sdk.version>20.3.0</graal-sdk.version>
<graal-sdk.version>20.3.1</graal-sdk.version>
<gizmo.version>1.0.6.Final</gizmo.version>
<jackson.version>2.12.1</jackson.version>
<commons-logging-jboss-logging.version>1.0.0.Final</commons-logging-jboss-logging.version>
Expand Down
4 changes: 2 additions & 2 deletions build-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<!-- These properties are needed in order for them to be resolvable by the documentation -->
<!-- The Graal version we suggest using in documentation - as that's
what we work with by self downloading it: -->
<graal-sdk.version-for-documentation>20.3.0</graal-sdk.version-for-documentation>
<graal-sdk.version-for-documentation>20.3.1</graal-sdk.version-for-documentation>
<mandrel.version-for-documentation>20.3</mandrel.version-for-documentation>
<rest-assured.version>4.3.2</rest-assured.version>
<axle-client.version>1.1.0</axle-client.version>
Expand Down Expand Up @@ -127,7 +127,7 @@
<revapi.checkdeps>false</revapi.checkdeps>

<!-- platform properties -->
<platform.quarkus.native.builder-image>quay.io/quarkus/ubi-quarkus-native-image:20.3.0-java11</platform.quarkus.native.builder-image>
<platform.quarkus.native.builder-image>quay.io/quarkus/ubi-quarkus-native-image:20.3.1-java11</platform.quarkus.native.builder-image>

<script.extension>sh</script.extension>
<docker-prune.location>${maven.multiModuleProjectDirectory}/.github/docker-prune.${script.extension}</docker-prune.location>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import io.quarkus.deployment.builditem.nativeimage.NativeImageResourceDirectoryBuildItem;
import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
import io.quarkus.deployment.pkg.steps.NativeBuild;
import io.quarkus.deployment.util.ServiceUtil;
import io.quarkus.tika.TikaParseException;
import io.quarkus.tika.runtime.TikaConfiguration;
Expand Down Expand Up @@ -69,17 +68,10 @@ FeatureBuildItem feature() {
return new FeatureBuildItem(Feature.TIKA);
}

@BuildStep(onlyIf = NativeBuild.class)
List<RuntimeInitializedClassBuildItem> runtimeInitImageIOClasses() {
return Arrays.asList(
//org.apache.tika.parser.pdf.PDFParser (https://issues.apache.org/jira/browse/PDFBOX-4548)
new RuntimeInitializedClassBuildItem("org.apache.pdfbox.pdmodel.font.PDType1Font"),
// The following classes hold instances of java.awt.color.ICC_ColorSpace that are not allowed in the
// image heap as this class should be initialized at image runtime
// See https://github.com/quarkusio/quarkus/pull/13644
new RuntimeInitializedClassBuildItem("org.apache.pdfbox.rendering.SoftMask"),
new RuntimeInitializedClassBuildItem(
"org.apache.pdfbox.pdmodel.graphics.color.PDCIEDictionaryBasedColorSpace"));
@BuildStep
public void registerRuntimeInitializedClasses(BuildProducer<RuntimeInitializedClassBuildItem> resource) {
//org.apache.tika.parser.pdf.PDFParser (https://issues.apache.org/jira/browse/PDFBOX-4548)
resource.produce(new RuntimeInitializedClassBuildItem("org.apache.pdfbox.pdmodel.font.PDType1Font"));
}

@BuildStep
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.quarkus.tika.runtime.graal;
package io.quarkus.tika.graalvm;

@com.oracle.svm.core.annotate.Substitute
@com.oracle.svm.core.annotate.TargetClass(className = "org.apache.poi.poifs.nio.CleanerUtil")
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion independent-projects/bootstrap/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<jboss-logmanager-embedded.version>1.0.5</jboss-logmanager-embedded.version>
<slf4j-jboss-logmanager.version>1.1.0.Final</slf4j-jboss-logmanager.version>
<slf4j-api.version>1.7.30</slf4j-api.version>
<graal-sdk.version>20.3.0</graal-sdk.version>
<graal-sdk.version>20.3.1</graal-sdk.version>
<plexus-classworlds.version>2.6.0</plexus-classworlds.version> <!-- not actually used but ClassRealm class is referenced from the API used in BootstrapWagonConfigurator -->
<version.surefire.plugin>3.0.0-M5</version.surefire.plugin>
<smallrye-common.version>1.5.0</smallrye-common.version>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package io.quarkus.it.corestuff;

import java.awt.image.BufferedImage;
import java.io.IOException;

import javax.imageio.ImageIO;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
Expand All @@ -12,10 +14,9 @@ public class ImageIOSupport extends HttpServlet {

@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
// Please uncomment this when we upgrade from GraalVM 20.3 to GraalVM 21
// ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
// BufferedImage image = ImageIO.read(classLoader.getResource("META-INF/resources/1px.png"));
// resp.getWriter().write(image.getHeight() + "x" + image.getWidth());
ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
BufferedImage image = ImageIO.read(classLoader.getResource("META-INF/resources/1px.png"));
resp.getWriter().write(image.getHeight() + "x" + image.getWidth());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static io.restassured.RestAssured.when;
import static org.hamcrest.Matchers.equalTo;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.QuarkusTest;
Expand All @@ -12,7 +11,6 @@
public class ImageIOTestCase {

@Test
@Disabled("Please bring this back when we upgrade from GraalVM 20.3 to GraalVM 21")
public void testImageRead() {
when().get("/core/imageio").then().body(equalTo("1x1"));
}
Expand Down