Deactivate Vault Config Source refresh if running in non blocking thread #16021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15821
I am not sure we can do better at this point. This means this is a slight regression compared to the previous implementation with with
okhttp
, where we would block on the vault call in the vertx thread (which is not good), but at least functionally, we would be able to refresh the cache.With the current implementation, we have to know that the vault config source cache refresh will only happen in non vertx threads. another approach would be to do the refresh from a timer, rather than doing it from the app thread. but this would require a dedicated thread. Ideally, it would be better to be able to register a callback on a central timer service.
In the meantime this fix will avoid the issue found in #15821