Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Vault Config Source refresh if running in non blocking thread #16021

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Deactivate Vault Config Source refresh if running in non blocking thread #16021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...nsions/vault/runtime/src/main/java/io/quarkus/vault/runtime/config/VaultConfigSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static java.util.Collections.emptyMap;
import static java.util.stream.Collectors.toMap;

import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand All @@ -14,6 +15,7 @@

import io.quarkus.arc.Arc;
import io.quarkus.vault.VaultKVSecretEngine;
import io.smallrye.mutiny.infrastructure.Infrastructure;

public class VaultConfigSource implements ConfigSource {

Expand Down Expand Up @@ -58,6 +60,11 @@ private Map<String, String> getSecretConfig() {
return cacheEntry.getValue();
}

if (!Infrastructure.canCallerThreadBeBlocked()) {
// running in a non blocking thread, best effort to return cached values if any
return cacheEntry != null ? cacheEntry.getValue() : Collections.emptyMap();
}

Map<String, String> properties = new HashMap<>();

try {
Expand Down