Improve IDE detection #18682
Improve IDE detection #18682
Conversation
* Test more possible cases for Windows * Support detection for multi-module projects Fixes: quarkusio#18676
|
This stuff looks really brittle. Is there any way we could think of having integration tests for such cases? Anyone from the IDE teams might be able to help @maxandersen ? (not meant to be a blocking remark on this particular PR, just a general thought) |
|
Yeah, I completely agree. The reason the PR is in draft is that I was OP to check it if possible |
|
@geoand FTR, the IdeProcessor is also not detecting idea when using fedora as os. I am investigating. |
I'm looking forward to what you find :) |
its brittle but thats the business of trying to detect this - users can always override. about integration tests this is probably something QE could add to their bigger setup tests - not sure IDE team can help here. |
maxandersen
added
the
triage/qe?
|
to QE: could you have tests with various IDE's on various platforms that could test these are detected ? |
|
Hi Max, sure we can. New automation and target environment preparation will be needed. For this effort, a new Feature Request needs to be created to define requirements (minimal set and the ideal set) and to prioritize it comparing to the other product requirements. |
|
@geoand I commited my fixes to https://github.com/Postremus/quarkus/commits/%2318676. How do we proceed from here, should I simply open a new PR? Essentially, idea is now opened correctly on fedora and windows. |
|
Cool. Please open a new PR (I will close this one) |
Fixes: #18676