Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IDE detection #18761

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Improve IDE detection #18761

merged 1 commit into from
Jul 20, 2021

Conversation

Postremus
Copy link
Member

  • Test more possible cases for idea
  • correctly add the line number argument for idea
  • Support detection for multi-module projects

Fixes: #18676
supersedes: #18682

@gsmet gsmet requested a review from geoand July 16, 2021 17:06
@geoand
Copy link
Contributor

geoand commented Jul 16, 2021

I'll check this and see if it works on my IntelliJ setup on Monday

geoand
geoand reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking to the time with this!

I added a couple of comments. Other than that, I tried it and it works on my setup

@Postremus
Improve IDE detection
ec335b6 
* Test more possible cases for idea
* correctly add the line argument for idea
* Support detection for multi-module projects

Fixes: quarkusio#18676
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1302f7e

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Initial JDK 11 Build ⚠️ Check → Logs Raw logs
⌛ Attach pull request number ⚠️ Check → Logs Raw logs
⌛ CI Sanity Check ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 19, 2021

Failing Jobs - Building ec335b6

Status Name Step Test failures Logs Raw logs
⌛ MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@Postremus
Copy link
Member Author

The ci failure does not look related, this pr does not change anything related to microprofile.

@geoand geoand merged commit 4b44958 into quarkusio:main Jul 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.2 - main milestone Jul 20, 2021
@Postremus Postremus deleted the #18676 branch July 20, 2021 05:22
@gsmet gsmet modified the milestones: 2.2 - main, 2.1.0.Final Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/vertx
Projects
None yet
Milestone
2.1.0.Final
Development

Successfully merging this pull request may close these issues.

Clicking on application class in stacktrace causes 500 in dev ui
3 participants
@Postremus @geoand @gsmet