Ensure mongo crypt does not brake in native #25716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
May 23, 2022
| @@ -260,4 +260,9 @@ final class JnaNativeSubstitutions { | |||
| public static String getWebStartLibraryPath(final String libName) { | |||
| return null; | |||
| } | |||
|
|
|||
| @Substitute | |||
| public static void register(Class<?> cls, String libName) { | |||
There was a problem hiding this comment.
Shouldn't we downgrade to the version that worked until we upgrade MongoDB? That's what I was planning to do today.
There was a problem hiding this comment.
I suppose we could just revert #25114.
There was a problem hiding this comment.
Yeah, that would have my preference.
There was a problem hiding this comment.
Yes, I prefere to revert it.
This library is an issue as it mandates an enterprise Mongo version to be testable.
Maybe we should conditionally include a substitution for mongo-crypt in case the library is not in the classpath and remove it from the extension dependencies.
|
Closing in favor of #25717 |
quarkus-bot
bot
added
triage/invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25711