Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mongo crypt does not brake in native #25716

Closed
wants to merge 1 commit into from
Closed

Ensure mongo crypt does not brake in native #25716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ient/runtime/src/main/java/io/quarkus/mongodb/runtime/graal/MongoClientSubstitutions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,4 +260,9 @@ final class JnaNativeSubstitutions {
public static String getWebStartLibraryPath(final String libName) {
return null;
}

@Substitute
public static void register(Class<?> cls, String libName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we downgrade to the version that worked until we upgrade MongoDB? That's what I was planning to do today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could just revert #25114.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would have my preference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay: #25717

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I prefere to revert it.

This library is an issue as it mandates an enterprise Mongo version to be testable.
Maybe we should conditionally include a substitution for mongo-crypt in case the library is not in the classpath and remove it from the extension dependencies.


}
}