Support config reactive datasource with list of database urls for fault tolerance and load balance #31994

benstonezhang · 2023-03-21T04:27:23Z

Add support to config load balance urls for reactive datasources in application.properties, for example:

quarkus.datasource.reactive.url=mysql://host1:3306/dbname,mysql://host2:3306/dbname,mysql://host3:3306/dbname

or

quarkus.datasource.reactive.url[0]=mysql://host1:3306/dbname
quarkus.datasource.reactive.url[1]=mysql://host2:3306/dbname
quarkus.datasource.reactive.url[2]=mysql://host3:3306/dbname

The original PR is #31852, which only update reactive mysql client. As @tsegismont suggested, I replaced public Optional<String> url with public Optional<List<String>> urls in DataSourceReactiveRuntimeConfig, and all of reactive database client were updated accordingly.

There is one exception: Vert.x oracle client already have build-in load balance support, and there is no such function like OraclePool.pool(Vertx vertx, List<OracleConnectOptions> databases, PoolOptions options). So only the first url is valid and others is discarded even if you config more urls.

The original PR title maybe improperly and misleading, so I create this one.

tsegismont

Thank you @benstonezhang

tsegismont · 2023-03-21T15:01:23Z

...me/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java

@@ -23,10 +24,10 @@ public class DataSourceReactiveRuntimeConfig {
    public boolean cachePreparedStatements = false;

    /**
-     * The datasource URL.
+     * The datasource URLs.


Can you please add a comment explaining that if multiple values are set, then the pool will be configured to create new connections using each of the urls, in a round-robin fashion?

tsegismont · 2023-03-22T10:40:50Z

...ient/runtime/src/main/java/io/quarkus/reactive/oracle/client/runtime/OraclePoolRecorder.java

@@ -112,7 +112,7 @@ private OracleConnectOptions toOracleConnectOptions(DataSourceRuntimeConfig data
            DataSourceReactiveOracleConfig dataSourceReactiveOracleConfig) {
        OracleConnectOptions oracleConnectOptions;
        if (dataSourceReactiveRuntimeConfig.url.isPresent()) {
-            String url = dataSourceReactiveRuntimeConfig.url.get();
+            String url = dataSourceReactiveRuntimeConfig.url.get().get(0);


Can you please log a warning if the user provides two or more urls for Oracle?

tsegismont · 2023-03-22T10:44:11Z

...reactive-db2-client/runtime/src/main/java/io/quarkus/reactive/db2/client/DB2PoolCreator.java

@@ -25,6 +27,6 @@ interface Input {

        PoolOptions poolOptions();

-        DB2ConnectOptions db2ConnectOptions();
+        List<DB2ConnectOptions> db2ConnectOptionsList();


For DB2, we should do the same as with Oracle (only log a warning if the user provides two or more urls).

tsegismont · 2023-03-22T10:44:39Z

...ve-mssql-client/runtime/src/main/java/io/quarkus/reactive/mssql/client/MSSQLPoolCreator.java

@@ -25,6 +27,6 @@ interface Input {

        PoolOptions poolOptions();

-        MSSQLConnectOptions msSQLConnectOptions();
+        List<MSSQLConnectOptions> msSQLConnectOptionsList();


For SQL Server, we should do the same as with Oracle (only log a warning if the user provides two or more urls).

tsegismont · 2023-03-22T13:54:19Z

...ient/deployment/src/test/java/io/quarkus/reactive/mysql/client/MySQLPoolLoadBalanceTest.java

+import io.quarkus.test.QuarkusDevModeTest;
+import io.restassured.RestAssured;
+
+public class MySQLPoolLoadBalanceTest {


Can you add a test for PostgreSQL too?

revised, please check.
For DB2 and SQL Server, as the Reactive DB2 Client and Reactive MSSQL Client documented, Vert.x do support advanced pool configuration:

DB2Pool pool = DB2Pool.pool(Arrays.asList(server1, server2, server3), options); MSSQLPool pool = MSSQLPool.pool(Arrays.asList(server1, server2, server3), options);

so I think we should support it too.

tsegismont

Thank you for the updates. Yes, in the Vert.x API / documentation it is possible but, in practice, I'm aware of multi-master systems only for MySQL, Postgres and Oracle.

For Oracle we can't support it the same way because the driver has to take care of it.

tsegismont · 2023-03-23T13:37:41Z

...ient/runtime/src/main/java/io/quarkus/reactive/oracle/client/runtime/OraclePoolRecorder.java

-            String url = dataSourceReactiveRuntimeConfig.url.get().get(0);
+            List<String> urls = dataSourceReactiveRuntimeConfig.url.get();
+            if (urls.size() > 1) {
+                log.warn("The Oracle driver does not support multiple URLs. This first is used, and others is ignored.");


Suggested change

log.warn("The Oracle driver does not support multiple URLs. This first is used, and others is ignored.");

log.warn("The Reactive Oracle Client does not support multiple URLs. The first one will be used, and others will be ignored.");

benstonezhang · 2023-03-23T14:13:22Z

I'm not family with DB2 and SQL Server. I will rework it tomorrow.

tsegismont · 2023-03-23T14:42:44Z

Thank you

…he ReactiveDialectWrapper

Bumps [mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md) - [Commits](mariadb-corporation/mariadb-connector-j@3.1.2...3.1.3) --- updated-dependencies: - dependency-name: org.mariadb.jdbc:mariadb-java-client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps `smallrye-open-api.version` from 3.3.0 to 3.3.1. Updates `smallrye-open-api-core` from 3.3.0 to 3.3.1 - [Release notes](https://github.com/smallrye/smallrye-open-api/releases) - [Commits](smallrye/smallrye-open-api@3.3.0...3.3.1) Updates `smallrye-open-api-jaxrs` from 3.3.0 to 3.3.1 Updates `smallrye-open-api-spring` from 3.3.0 to 3.3.1 Updates `smallrye-open-api-vertx` from 3.3.0 to 3.3.1 Updates `smallrye-open-api-ui` from 3.3.0 to 3.3.1 --- updated-dependencies: - dependency-name: io.smallrye:smallrye-open-api-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.smallrye:smallrye-open-api-jaxrs dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.smallrye:smallrye-open-api-spring dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.smallrye:smallrye-open-api-vertx dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.smallrye:smallrye-open-api-ui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

… specified in datasource url

benstonezhang · 2023-03-24T04:07:58Z

@tsegismont code updated, please check. Thx.

Fix quarkusio#32033

Ensure Dialects initialzed by Hibernate Reactive extension use the ReactiveDialectWrapper

Update SmallRye Config to 3.2.0

DevUI: Liquibase

Fix Kotlin formatting

Fix OTel exporter headers config

Allow using the annotation `@PartFilename` on method parameters

…g.mariadb.jdbc-mariadb-java-client-3.1.3 Bump mariadb-java-client from 3.1.2 to 3.1.3

…allrye-open-api.version-3.3.1 Bump smallrye-open-api.version from 3.3.0 to 3.3.1

tsegismont · 2023-03-24T14:17:43Z

Can you please rebase your PR rather than merging the main branch into your branch?

… specified in datasource url

…tive-db-conn-pool

github-actions · 2023-03-24T15:54:33Z

🙈 The PR is closed and the preview is expired.

… specified in datasource url

…ang/quarkus into reactive-db-conn-pool

tsegismont · 2023-03-24T16:12:40Z

It doesn't look good @benstonezhang

benstonezhang · 2023-03-24T16:20:53Z

just done rebase and push

quarkus-bot · 2023-03-24T17:23:03Z

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

benstonezhang · 2023-03-25T04:14:32Z

@tsegismont Sorry, seems I had messed this branch. I create a new PR #32128, please check.

support config reactive datasource with list of urls

c2bf298

quarkus-bot bot added area/persistence OBSOLETE, DO NOT USE area/reactive-sql-clients labels Mar 21, 2023

benstonezhang changed the title ~~Support config reactive datasource with list of urls for fault tolerance and load balance~~ Support config reactive datasource with list of database urls for fault tolerance and load balance Mar 21, 2023

benstonezhang mentioned this pull request Mar 21, 2023

Support fault tolerance and load balance with vert.x pool of reactive mysql client #31852

Closed

tsegismont reviewed Mar 22, 2023

View reviewed changes

revised comments; add test for db2, mssql and pg

f393ecf

tsegismont reviewed Mar 23, 2023

View reviewed changes

Fix OTel exporter headers config

f4ac273

Sanne and others added 8 commits March 23, 2023 18:40

Ensure Dialects initialized by the Hibernate Reactive extension use t…

075a586

…he ReactiveDialectWrapper

Update SmallRye Config to 3.2.0

35b333f

Update SmallRye Config to 3.2.0

9fb6afd

DevUI: Liquibase

378dbb6

Merge remote-tracking branch 'origin/main' into reactive-db-conn-pool

7adf923

revert change made for db2 and mssql; update warning for multi values…

478c660

… specified in datasource url

Sgitario and others added 10 commits March 24, 2023 07:19

Allow using the annotation @PartFilename on method parameters

b3b5c03

Fix quarkusio#32033

Fix Kotlin formatting

e6baa3c

Merge pull request quarkusio#32086 from Sanne/HRDialectWrapping

14d12e8

Ensure Dialects initialzed by Hibernate Reactive extension use the ReactiveDialectWrapper

Merge pull request quarkusio#31824 from radcortez/srconfig-3.2.0

09fb411

Update SmallRye Config to 3.2.0

Merge pull request quarkusio#32091 from melloware/devui-liquibase

b4a92c8

DevUI: Liquibase

Merge pull request quarkusio#32100 from geoand/kotlin

125f884

Fix Kotlin formatting

Merge pull request quarkusio#32073 from brunobat/fix-header-docs

d15dff6

Fix OTel exporter headers config

Merge pull request quarkusio#32099 from Sgitario/32033

1d53bbf

Allow using the annotation `@PartFilename` on method parameters

Merge pull request quarkusio#32094 from quarkusio/dependabot/maven/or…

66c9dd2

…g.mariadb.jdbc-mariadb-java-client-3.1.3 Bump mariadb-java-client from 3.1.2 to 3.1.3

Merge pull request quarkusio#32095 from quarkusio/dependabot/maven/sm…

2647d64

…allrye-open-api.version-3.3.1 Bump smallrye-open-api.version from 3.3.0 to 3.3.1

benstonezhang added 4 commits March 24, 2023 23:13

support config reactive datasource with list of urls

0ddddfb

revised comments; add test for db2, mssql and pg

28ad2ce

revert change made for db2 and mssql; update warning for multi values…

42a6232

… specified in datasource url

Merge remote-tracking branch 'origin/reactive-db-conn-pool' into reac…

6eb3c0f

…tive-db-conn-pool

benstonezhang added 4 commits March 25, 2023 00:01

support config reactive datasource with list of urls

c0f173d

revised comments; add test for db2, mssql and pg

7bed2ce

revert change made for db2 and mssql; update warning for multi values…

8e54ba3

… specified in datasource url

Merge branch 'reactive-db-conn-pool' of https://github.com/benstonezh…

5a963dc

…ang/quarkus into reactive-db-conn-pool

benstonezhang closed this Mar 25, 2023

quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support config reactive datasource with list of database urls for fault tolerance and load balance #31994

Support config reactive datasource with list of database urls for fault tolerance and load balance #31994

benstonezhang commented Mar 21, 2023

tsegismont left a comment

tsegismont Mar 21, 2023

tsegismont Mar 22, 2023

tsegismont Mar 22, 2023

tsegismont Mar 22, 2023

tsegismont Mar 22, 2023

benstonezhang Mar 23, 2023

tsegismont left a comment

tsegismont Mar 23, 2023

benstonezhang commented Mar 23, 2023

tsegismont commented Mar 23, 2023 via email

benstonezhang commented Mar 24, 2023

tsegismont commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 •

edited

Loading

tsegismont commented Mar 24, 2023

benstonezhang commented Mar 24, 2023

quarkus-bot bot commented Mar 24, 2023

benstonezhang commented Mar 25, 2023

	log.warn("The Oracle driver does not support multiple URLs. This first is used, and others is ignored.");
	log.warn("The Reactive Oracle Client does not support multiple URLs. The first one will be used, and others will be ignored.");

Support config reactive datasource with list of database urls for fault tolerance and load balance #31994

Support config reactive datasource with list of database urls for fault tolerance and load balance #31994

Conversation

benstonezhang commented Mar 21, 2023

tsegismont left a comment

Choose a reason for hiding this comment

tsegismont Mar 21, 2023

Choose a reason for hiding this comment

tsegismont Mar 22, 2023

Choose a reason for hiding this comment

tsegismont Mar 22, 2023

Choose a reason for hiding this comment

tsegismont Mar 22, 2023

Choose a reason for hiding this comment

tsegismont Mar 22, 2023

Choose a reason for hiding this comment

benstonezhang Mar 23, 2023

Choose a reason for hiding this comment

tsegismont left a comment

Choose a reason for hiding this comment

tsegismont Mar 23, 2023

Choose a reason for hiding this comment

benstonezhang commented Mar 23, 2023

tsegismont commented Mar 23, 2023 via email

benstonezhang commented Mar 24, 2023

tsegismont commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 • edited Loading

tsegismont commented Mar 24, 2023

benstonezhang commented Mar 24, 2023

quarkus-bot bot commented Mar 24, 2023

benstonezhang commented Mar 25, 2023

github-actions bot commented Mar 24, 2023 •

edited

Loading