-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support config reactive datasource with list of database urls for fault tolerance and load balance #31994
Support config reactive datasource with list of database urls for fault tolerance and load balance #31994
Changes from 1 commit
c2bf298
f393ecf
f4ac273
075a586
35b333f
9fb6afd
378dbb6
cf2c950
2e02dcc
7adf923
478c660
b3b5c03
e6baa3c
14d12e8
09fb411
b4a92c8
125f884
d15dff6
1d53bbf
66c9dd2
2647d64
0ddddfb
28ad2ce
42a6232
6eb3c0f
c0f173d
7bed2ce
8e54ba3
5a963dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
package io.quarkus.reactive.db2.client; | ||
|
||
import java.util.List; | ||
|
||
import io.quarkus.reactive.datasource.ReactiveDataSource; | ||
import io.vertx.core.Vertx; | ||
import io.vertx.db2client.DB2ConnectOptions; | ||
|
@@ -25,6 +27,6 @@ interface Input { | |
|
||
PoolOptions poolOptions(); | ||
|
||
DB2ConnectOptions db2ConnectOptions(); | ||
List<DB2ConnectOptions> db2ConnectOptionsList(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For DB2, we should do the same as with Oracle (only log a warning if the user provides two or more urls). |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
package io.quarkus.reactive.mssql.client; | ||
|
||
import java.util.List; | ||
|
||
import io.quarkus.reactive.datasource.ReactiveDataSource; | ||
import io.vertx.core.Vertx; | ||
import io.vertx.mssqlclient.MSSQLConnectOptions; | ||
|
@@ -25,6 +27,6 @@ interface Input { | |
|
||
PoolOptions poolOptions(); | ||
|
||
MSSQLConnectOptions msSQLConnectOptions(); | ||
List<MSSQLConnectOptions> msSQLConnectOptionsList(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For SQL Server, we should do the same as with Oracle (only log a warning if the user provides two or more urls). |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment explaining that if multiple values are set, then the pool will be configured to create new connections using each of the urls, in a round-robin fashion?