Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Findability enhancement for landing page issue: Reactive doc search yields zero results #33486

Closed

Conversation

michelle-purcell
Copy link
Contributor

Fixes:

When you select the Reactive category on the doc landing page, you get zero results.
image

How?
In this PR I added the reactive keyword to the doc header :categories:where the keyword was mentioned >10 times OR featured in the main title or summary. Plus some other obviously missing categories. There might be others that slipped though the net.

@michelle-purcell michelle-purcell force-pushed the doc-search-enhancement branch from 9a8b9c7 to 7e6068e Compare May 19, 2023 09:54
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/funqy labels May 19, 2023
@michelle-purcell michelle-purcell force-pushed the doc-search-enhancement branch from 7e6068e to 4cd3fdb Compare May 19, 2023 09:57
@github-actions
Copy link

github-actions bot commented May 19, 2023

🎊 PR Preview 32f52e2 has been successfully built and deployed to https://quarkus-pr-main-33486-preview.surge.sh/version/main/guides/

@quarkus-bot
Copy link

quarkus-bot bot commented May 19, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented May 23, 2023

@michelle-purcell looks like you discovered my evil plan!

@michelle-purcell michelle-purcell force-pushed the doc-search-enhancement branch from 4e87b25 to 9b19825 Compare May 23, 2023 11:16
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to discuss this with @cescoffier .

What I'm wondering is: should we mark everything that is reactive with this category, meaning most of our extensions or should we focus on guides that actually talks about the reactive bits. I will let @cescoffier decide on that one.

@cescoffier
Copy link
Member

Why is reactive a category in the first place?

If we want to keep it as a category, we can 1) list most extensions [useless, IMHO], 2) select a set of guides using reactve programming (mutiny, resteasy reactive, reactive rest client...)

@gsmet
Copy link
Member

gsmet commented Jun 6, 2023

I'm not sure what to do about this?

@michelle-purcell
Copy link
Contributor Author

Thanks @gsmet. I'm not sure either.

If we close this PR without merging because the category 'Reactive' is too broad then perhaps we should consider removing the category 'Reactive' from the docs for now.

If we don't do anything, we have a broken docs experience on the landing page.

@cescoffier or @ebullient - What do you think?
Thanks

@cescoffier
Copy link
Member

We should remove the reactive category

@michelle-purcell
Copy link
Contributor Author

Thanks @cescoffier for confirming.

I will now proceed to update this PR to remove the reactive from all documents (by rebasing) and then remove the 'Reactive' category from elsewhere in the landing page config/architecture. Thanks. BRB...

@michelle-purcell
Copy link
Contributor Author

michelle-purcell commented Jun 12, 2023

The changes in this PR are now reverted and I updated the list of doc categories to remove the reactive label as per this new PR : #33992
@gsmet & @cescoffier - Thanks for your help getting this to resolution 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/funqy triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants