-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Findability enhancement for landing page issue: Reactive doc search yields zero results #33486
Findability enhancement for landing page issue: Reactive doc search yields zero results #33486
Conversation
9a8b9c7
to
7e6068e
Compare
7e6068e
to
4cd3fdb
Compare
🎊 PR Preview 32f52e2 has been successfully built and deployed to https://quarkus-pr-main-33486-preview.surge.sh/version/main/guides/ |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
4cd3fdb
to
4e87b25
Compare
@michelle-purcell looks like you discovered my evil plan! |
4e87b25
to
9b19825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to discuss this with @cescoffier .
What I'm wondering is: should we mark everything that is reactive with this category, meaning most of our extensions or should we focus on guides that actually talks about the reactive bits. I will let @cescoffier decide on that one.
Why is reactive a category in the first place? If we want to keep it as a category, we can 1) list most extensions [useless, IMHO], 2) select a set of guides using reactve programming (mutiny, resteasy reactive, reactive rest client...) |
I'm not sure what to do about this? |
Thanks @gsmet. I'm not sure either. If we close this PR without merging because the category 'Reactive' is too broad then perhaps we should consider removing the category 'Reactive' from the docs for now. If we don't do anything, we have a broken docs experience on the landing page. @cescoffier or @ebullient - What do you think? |
We should remove the reactive category |
Thanks @cescoffier for confirming. I will now proceed to update this PR to remove the |
9b19825
to
503d9e5
Compare
The changes in this PR are now reverted and I updated the list of doc categories to remove the |
Fixes:
When you select the

Reactive
category on the doc landing page, you get zero results.How?
In this PR I added the
reactive
keyword to the doc header:categories:
where the keyword was mentioned >10 times OR featured in the main title or summary. Plus some other obviously missing categories. There might be others that slipped though the net.