Remove 'Reactive' as a category for docs #33992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cescoffier - FYI. |
ebullient
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
You may hit a conflict w/ this file and the other PR, as I'm seeing similar changes. I think the only one you intend here is removal of like 395 (removing reactive from table)
|
🙈 The PR is closed and the preview is expired. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this problem:
On the Quarkus doc landing page, when you filter the guides by selecting the "Reactive" category, zero results display.
This is because none of the guides use the
categories: reactiveattribute.Solution
Remove the
reactivecategory from the current doc taxonomy.Context
In PR #33486 @cescoffier concluded that we should remove this category from the docs filter list, as per the following rationale: