Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP and RestEasy-related content review #36661

Merged

Conversation

MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Oct 24, 2023

This is the docs team follow-up of the @sberyozkin 's PR https://github.com/quarkusio/quarkus/pull/36541/files

This PR will need to be rebased when the #36667 is merged so that we have separated commits for these fixes and fixes only related to the CORS content.

@MichalMaler MichalMaler changed the title Review of the Corse related content Review of the CORS-related content Oct 24, 2023
@MichalMaler MichalMaler force-pushed the Review-of-the-Corse-related-content branch from 65aa3b7 to 6a0fc55 Compare October 24, 2023 11:52
@MichalMaler
Copy link
Contributor Author

@jmartisk Thanks for always great and quick review! Applied all your suggestions, squashed the commits and did a rebase. This version should be good now for @sberyozkin final check.

@MichalMaler MichalMaler requested a review from jmartisk October 24, 2023 11:54
@sberyozkin
Copy link
Member

Thanks @MichalMaler for the PR, LGTM overall, but propose to keep non-CORS related updates in another PR, or at least in a dedicated commit of its own; added a couple of minor enough suggestions related to the CORS content, cheers

@MichalMaler MichalMaler force-pushed the Review-of-the-Corse-related-content branch from 6a0fc55 to 38c04ba Compare October 24, 2023 13:45
@MichalMaler MichalMaler marked this pull request as draft October 24, 2023 14:13
@MichalMaler MichalMaler removed the request for review from michelle-purcell October 24, 2023 14:13
@MichalMaler MichalMaler changed the title Review of the CORS-related content Review of some minor things I spot during the CORS-related content review Oct 24, 2023
@MichalMaler
Copy link
Contributor Author

Thanks @MichalMaler for the PR, LGTM overall, but propose to keep non-CORS related updates in another PR, or at least in a dedicated commit of its own; added a couple of minor enough suggestions related to the CORS content, cheers

Hello! Sure. Creating a separate PR was quicker for me, so here it is :) #36667

This PR can be merged after #36667 is merged and this PR is rebased.

@sberyozkin
Copy link
Member

Sounds good @MichalMaler, thanks for the patience, cheers

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🙈 The PR is closed and the preview is expired.

@MichalMaler MichalMaler requested a review from geoand October 24, 2023 15:18
@sberyozkin sberyozkin changed the title Review of some minor things I spot during the CORS-related content review HTTP and RestEasy-related content review Oct 24, 2023
@sberyozkin
Copy link
Member

Hi @MichalMaler I updated the title a bit now that it is pure HTTP and RestEasy related updates, thanks

@sberyozkin
Copy link
Member

Please sort out the conflicts

@sberyozkin sberyozkin self-requested a review October 24, 2023 18:02
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an approval for completeness now that Georgios approved

@MichalMaler MichalMaler marked this pull request as ready for review October 25, 2023 11:47
@MichalMaler MichalMaler force-pushed the Review-of-the-Corse-related-content branch from 38c04ba to 086ee1c Compare October 25, 2023 12:47
@sberyozkin
Copy link
Member

Michal, not sure that the cors doc commit should be in this PR ?

resteasy.adoc sanity check

Signed-off-by: Michal Maléř <[email protected]>
@MichalMaler MichalMaler force-pushed the Review-of-the-Corse-related-content branch from 086ee1c to a8945f0 Compare October 25, 2023 13:16
@MichalMaler
Copy link
Contributor Author

Michal, not sure that the cors doc commit should be in this PR ?

Oh, no worries, that was just a left over of my actions in the past. I squashed the commits and rename it so that it match our current intention and the heading you proposed :)

@sberyozkin
Copy link
Member

Thanks @MichalMaler

@sberyozkin sberyozkin merged commit f321dc0 into quarkusio:main Oct 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 25, 2023
@MichalMaler MichalMaler deleted the Review-of-the-Corse-related-content branch October 25, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants