-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP and RestEasy-related content review #36661
HTTP and RestEasy-related content review #36661
Conversation
65aa3b7
to
6a0fc55
Compare
@jmartisk Thanks for always great and quick review! Applied all your suggestions, squashed the commits and did a rebase. This version should be good now for @sberyozkin final check. |
Thanks @MichalMaler for the PR, LGTM overall, but propose to keep non-CORS related updates in another PR, or at least in a dedicated commit of its own; added a couple of minor enough suggestions related to the CORS content, cheers |
6a0fc55
to
38c04ba
Compare
Hello! Sure. Creating a separate PR was quicker for me, so here it is :) #36667 This PR can be merged after #36667 is merged and this PR is rebased. |
Sounds good @MichalMaler, thanks for the patience, cheers |
🙈 The PR is closed and the preview is expired. |
Hi @MichalMaler I updated the title a bit now that it is pure HTTP and RestEasy related updates, thanks |
Please sort out the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding an approval for completeness now that Georgios approved
38c04ba
to
086ee1c
Compare
Michal, not sure that the cors doc commit should be in this PR ? |
resteasy.adoc sanity check Signed-off-by: Michal Maléř <[email protected]>
086ee1c
to
a8945f0
Compare
Oh, no worries, that was just a left over of my actions in the past. I squashed the commits and rename it so that it match our current intention and the heading you proposed :) |
Thanks @MichalMaler |
This is the docs team follow-up of the @sberyozkin 's PR https://github.com/quarkusio/quarkus/pull/36541/files
This PR will need to be rebased when the #36667 is merged so that we have separated commits for these fixes and fixes only related to the CORS content.