-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS content review #36667
CORS content review #36667
Conversation
Signed-off-by: Michal Maléř <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MichalMaler, @jmartisk, sorry for the hassle with having it opened in a dedicated PR, but hope you'll find it easier to deal with various backport requirements later
Cool. No worries. Please attach the needed labels and feel free to merge :) |
@rsvoboda Hello Rostislav! Do we want this PR to be backported to 3.2? |
🎊 PR Preview ee1d5a3 has been successfully built and deployed to https://quarkus-pr-main-36667-preview.surge.sh/version/main/guides/ |
PR looks good to me, thanks @MichalMaler @sberyozkin there are quite a few changes going on around security guides, they should be probably marked for backport to 3.2 because security guides are planned for downstream. WDYT? Or we can process what's available in 3.2 branch and pick the current (and future) changes in the next feature release. |
Creating this PR to separate pure CORS content from the already opened PR that mix the same changes as this PR with some other fixes that got into my cross hair.
This is the docs team follow-up of the @sberyozkin 's PR https://github.com/quarkusio/quarkus/pull/36541/files
This PR already contains SME review of @sberyozkin and @jmartisk .