Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ConfigItem Javadocs in jdp files without timestamps #38421

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

yurloc
Copy link
Contributor

@yurloc yurloc commented Jan 26, 2024

Fixes #38420.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you put me to shame @yurloc I completely missed it. Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 26, 2024
Copy link

quarkus-bot bot commented Jan 26, 2024

Failing Jobs - Building bfc635c

Status Name Step Failures Logs Raw logs Build scan
Maven Tests - JDK 17 Build Failures Logs Raw logs 🔍
✔️ Maven Tests - JDK 17 Windows 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Maven Tests - JDK 17 #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "63c24bfd-47ad-4f20-b743-ba825dad4b45" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 967 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "63c24bfd-47ad-4f20-b743-ba825dad4b45" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit a79a975 into quarkusio:main Jan 27, 2024
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 27, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 27, 2024
@yurloc yurloc deleted the reproducible-jdp branch January 27, 2024 09:51
@yurloc
Copy link
Contributor Author

yurloc commented Jan 27, 2024

Ok, you put me to shame @yurloc I completely missed it. Thanks!

I didn't mean to 🙂 But since you mentioned it needs a separate issue I wanted to do my homework and find out where the .jdp files come from (I wasn't even sure it's from Quarkus). When it turned out to be a one-line fix, opening a PR was easy.

Thanks for the quick response!

@gsmet gsmet modified the milestones: 3.9 - main, 3.7.1 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamps in jdp files prevent reproducible extension builds
4 participants