Made the tests pass for me #4340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested changes
Oct 3, 2019
| @@ -18,6 +19,10 @@ | |||
|
|
|||
| public static final String HEADER_NAME = "header-name"; | |||
|
|
|||
| // this is required, otherwise the test.url system property is never set | |||
| @TestHTTPResource | |||
There was a problem hiding this comment.
I think it would be better to change the code to always set the property.
There was a problem hiding this comment.
Fine by me, but then where/how?
|
Closing in favour of #4390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now go figure why you guys can get your tests to run despite not having anyone set the
test.urlsystem property in that damn test.