Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the tests pass for me #4340

Closed
wants to merge 1 commit into from
Closed

Made the tests pass for me #4340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions integration-tests/main/src/test/java/io/quarkus/it/main/RestClientTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.common.http.TestHTTPResource;
import io.quarkus.test.junit.QuarkusTest;
import io.restassured.RestAssured;
import io.restassured.path.json.JsonPath;
Expand All @@ -18,6 +19,10 @@ public class RestClientTestCase {

public static final String HEADER_NAME = "header-name";

// this is required, otherwise the test.url system property is never set
@TestHTTPResource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to change the code to always set the property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but then where/how?

private String url;

@Test
public void testMicroprofileClient() {
RestAssured.when().get("/client/manual").then()
Expand Down
2 changes: 1 addition & 1 deletion test-framework/junit5-internal/src/main/java/io/quarkus/test/QuarkusDevModeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ public void sleepForFileChanges(Path path) {
if (fm > currentTime) {
return;
}
Thread.sleep(50);
Thread.sleep(200);
}
} catch (Exception e) {
throw new RuntimeException(e);
Expand Down