Ensure that final methods don't prevent CDI interceptors from being applied

[geoand]

We need security annotations to result in the creation of an interceptor
which is not possible when a method is final.
The solution we follow is to remove the final modifier from methods
that need intercepting.
This is now configurable with the default value true, meaning that
Arc will remove the final flag. If the value is set to false
Arc throws an exception at build time.

Fixes: #5051

Provides an alternative implementation to #5089 (which has now been closed) based on this comment

[geoand]

I need to rebase this on top of #5108

[geoand]

This is now rebased on top of #5108.

[geoand]

I cleared the milestone since it remains to be decided if it should go in for 0.28

[gsmet]

Decision on this one is to wait a bit and see the feedback we have on Martin's changes before deciding if we should take the risk to include it pre 0.29.0.

[geoand]

Note to self: rebase onto master and get this one in for 1.1

[geoand]

@mkouba @gsmet should we get this one in for 1.1?

[manovotn]

Looks good to me and +1 for tests for both cases right away!
I am not familiar with ClassVisitor pattern, so take my review there with a pinch of salt, but it does seem to do what I'd expect it to do ;-)

[geoand]

Thanks for the review @manovotn!

I'll wait for another review then :)

[geoand]

@mkouba / @stuartwdouglas are you good with this?

[stuartwdouglas]

LGTM but I will let @mkouba have the final say.

[mkouba]

Looks really good! The only thing I'm missing is a log message that a final modifier was removed. I know that users usually don't care about these messages but it's a good habit that helps with debugging ;-).

[stuartwdouglas]

It should be debug level though

[geoand]

I added a debug level logging message

[mkouba]

[ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.8.1:validate (default) on project arc-processor: File '/home/vsts/work/1/s/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Methods.java' has not been previously formatted. Please format file and commit before running validation! -> [Help 1]
[ERROR]

@geoand ;-)

[geoand]

[ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.8.1:validate (default) on project arc-processor: File '/home/vsts/work/1/s/independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Methods.java' has not been previously formatted. Please format file and commit before running validation! -> [Help 1]
[ERROR]

@geoand ;-)

LOL, I'll fix it :)